After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 433655 - [verified] Orca's structural navigation should wrap at the end of a page
[verified] Orca's structural navigation should wrap at the end of a page
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: general
2.19.x
Other All
: Normal enhancement
: 2.20.0
Assigned To: Joanmarie Diggs (IRC: joanie)
Orca Maintainers
Depends on:
Blocks: 404403
 
 
Reported: 2007-04-26 17:41 UTC by Mike Pedersen
Modified: 2008-07-22 19:27 UTC
See Also:
GNOME target: ---
GNOME version: 2.17/2.18

Attachments
proposed patch (26.99 KB, patch)
2007-05-19 22:29 UTC, Joanmarie Diggs (IRC: joanie) 		committed Details | Review

Description Mike Pedersen 2007-04-26 17:41:29 UTC 
When using orca's navigation keys to move through a page orca currently stops at the end of the page and says no more xyzs.  I'd like to see this behavior changed to wrap around to the top of the page.  This will make the behavior more similar to tabbing through a page.  
The new messages should be either "no xyzs" or "wrapping" and do the usual behavior.
Comment 1 Joanmarie Diggs (IRC: joanie) 2007-05-19 22:29:14 UTC 
Created attachment 88458 [details] [review]
proposed patch

> The new messages should be either "no xyzs" or "wrapping" and do the usual
> behavior.

Which should it be? Also should we indicate the direction in which we are wrapping (i.e. "wrapping to top"/"wrapping to bottom")?  

Since you had provided me with a choice, I went with "wrapping". <smile>  Personally, I think it's good to indicate the direction as well, so I did that too.  Please give it a spin and let me know if it works for you and if you'd like anything changed about what is spoken.  Thanks!
Comment 2 Mike Pedersen 2007-05-20 17:38:28 UTC 
I've been testing this patch this weekend and I'm quite happy with it.  I also like the extra messages that were added.  
thanks much Joanie
Comment 3 Joanmarie Diggs (IRC: joanie) 2007-05-20 18:10:59 UTC 
Thanks Mike.

Will, okay to check this in?
Comment 4 Willie Walker 2007-05-21 18:47:14 UTC 
Looks fine to me.  Thanks for adding the comments for the translators.  :-)
Comment 5 Joanmarie Diggs (IRC: joanie) 2007-05-21 19:00:33 UTC 
Thanks for the review!  Updating the status to pending.
Comment 6 Mike Pedersen 2007-05-21 19:29:57 UTC 
I've tested this on several pages and it seems to work nicely.  thanks much