After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 433537 - [Rendering] Recover properly from errors
[Rendering] Recover properly from errors
Status: RESOLVED FIXED
Product: pitivi
Classification: Other
Component: Rendering
Git
Other Linux
: Normal normal
: 0.91
Assigned To: Pitivi maintainers
Pitivi maintainers
: 433574 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-04-26 09:00 UTC by Edward Hervey
Modified: 2013-09-21 19:36 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Edward Hervey 2007-04-26 09:00:14 UTC 
When an error happens in rendering (exception being raised for ex), a lot of issues happen after that when trying to close the rendering window.

Ex :

Traceback (most recent call last):

+ Trace 130648

  • File "/home/bilboed/work/cvs/pitivi/pitivi/ui/mainwindow.py", line 439 in _cancelButtonClickedCb 
    self.bin.stopRecording()
  • File "/home/bilboed/work/cvs/pitivi/pitivi/bin.py", line 238 in stopRecording 
    self.getRealVideoSink().set_property("sync", True)
AttributeError: 'NoneType' object has no attribute 'set_property' 






Comment 1


Edward Hervey





          2007-04-26 11:25:21 UTC
        



*** Bug 433574 has been marked as a duplicate of this bug. ***






Comment 2


Jean-François Fortin Tam





          2013-09-21 19:36:29 UTC
        



Fixed through bug #635874, actually: we just don't accept rendering errors and bail out completely.



commit 44efa7d32f0270c31063603fc0a15a558a0e7249
Author: Jean-François Fortin Tam <nekohayo@gmail.com>
Date:   Mon Apr 29 15:23:25 2013 +0100

  render: Show a more human-readable message when an error occurs in the
pipeline

  Hide the gory details in a GTK Expander widget

commit a7877f902b552935e203fbe99ee7f14f0697aae6
Author: Jean-François Fortin Tam <nekohayo@gmail.com>
Date:   Sat Apr 27 20:32:11 2013 -0400

    ui/filelisterrordialog: Set the GTK box orientation to be vertical

    This also updates the GtkBuilder file's syntax to Glade's latest tastes

commit e70b0550210d9afe3677e866ee80af096c801e6b
Author: Jean-François Fortin Tam <nekohayo@gmail.com>
Date:   Sat Apr 27 20:27:49 2013 -0400

    render:  Show rendering errors in a dialog

    Abort rendering when an error is encountered in the pipeline,
    show the error so that the user actually knows something went wrong.

    Fixes bug #635874