After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 433431 - Firefox list role not announced when skipping setting is "report"
Firefox list role not announced when skipping setting is "report"
Status: RESOLVED FIXED
Product: lsr
Classification: Deprecated
Component: extensions
0.5.x
Other Linux
: Normal normal
: 0.5.2
Assigned To: Peter Parente
LSR maintainers
Depends on:
Blocks:
 
 
Reported: 2007-04-25 20:39 UTC by Peter Parente
Modified: 2007-04-26 13:23 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Peter Parente 2007-04-25 20:39:24 UTC
I believe the problem is in FirefoxPerk's should skip task:

    elif skipping == AEConstants.SKIP_REPORT:
      if not peek:
        role = self.getAccRole(por=por)
        # then invoke the review report task
        if role == 'table' and not self.perk.isLayoutTable(por, role):
          # update the Perk object's task_por
          self.moveToPOR(por)
          self.doTask('review skip report')
        else:
          self.moveToPOR(por)
        # indicate something has been skipped and reported
        self.setTempVal('has skipped', True)        
      else:
        # indicate something will be skipped and reported
        self.setTempVal('will skip', True)
      self.setTempVal('should skip', True)

Notice we only invoke 'review skip report' in the table case. But what about other things that have been skipped? The code wasn't originally like this, so why did we factor out tables as a special case?

I bet we wanted the inverse logic to apply to layout tables. But as written, it's applying to *anything* that isn't a data table.
Comment 1 Peter Parente 2007-04-26 13:23:50 UTC
This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.