After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 432674 - [pending] In password entries, Orca should respect key echo settings and say "star" for the inserted characters
[pending] In password entries, Orca should respect key echo settings and say ...
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: speech
2.19.x
Other All
: Normal normal
: ---
Assigned To: Orca Maintainers
Orca Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-04-23 16:45 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2007-05-01 19:58 UTC
See Also:
GNOME target: ---
GNOME version: 2.17/2.18

Attachments
patch to address both issues (995 bytes, patch)
2007-04-23 16:47 UTC, Joanmarie Diggs (IRC: joanie) 		committed Details | Review
revision based on user feedback to only echo if "printable" key echoing is enabled (644 bytes, patch)
2007-04-23 20:27 UTC, Joanmarie Diggs (IRC: joanie) 		committed Details | Review

Description Joanmarie Diggs (IRC: joanie) 2007-04-23 16:45:40 UTC 
As commented upon in bug #416971, the addition of bullet names to chnames.py has had the side effect of causing Orca to say "black circle" for each character inserted into a password entry.  There are, IMHO, two issues here:

1. "black circle" is too verbose; we should be saying "star" (i.e. "*")

2. We should be respecting the key echo setting.  In other words, if key echo by character is not enabled, we should not be echoing each character that is inserted into a password entry any more than we would in a non-password entry. :-)
Comment 1 Joanmarie Diggs (IRC: joanie) 2007-04-23 16:47:49 UTC 
Created attachment 86859 [details] [review]
patch to address both issues
Comment 2 Joanmarie Diggs (IRC: joanie) 2007-04-23 16:55:45 UTC 
Per Will:  Checking this in and marking as pending.
Comment 3 Joanmarie Diggs (IRC: joanie) 2007-04-23 20:27:14 UTC 
Created attachment 86875 [details] [review]
revision based on user feedback to only echo if "printable" key echoing is enabled

Hermann pointed out that my patch was echoing if key echo by char was enabled period.  It should only echo if key echo by char is enabled *and* the echoing of printable characters is enabled.  This patch does this.  Hermann has tested it and agrees that it solves the problem.
Comment 4 Joanmarie Diggs (IRC: joanie) 2007-04-23 20:33:16 UTC 
patch committed.
Comment 5 Joanmarie Diggs (IRC: joanie) 2007-05-01 19:58:03 UTC 
Closing as FIXED.