After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 432228 - [Python bindings] New-style constructors
[Python bindings] New-style constructors
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: Programmatic interfaces
HEAD
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-04-22 11:45 UTC by Tim Retout
Modified: 2007-08-26 06:04 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Update constructors to new style (2.24 KB, patch)
2007-04-22 12:01 UTC, Tim Retout
none Details | Review

Description Tim Retout 2007-04-22 11:45:29 UTC
When building the Python bindings, there are several warnings about constructors.

Warning: generating old-style constructor for:rb_entry_view_new
Warning: generating old-style constructor for:rb_library_browser_new
Warning: generating old-style constructor for:rb_song_info_new

Warning: Constructor for RBSourceList needs to be updated to new API
         See http://live.gnome.org/PyGTK_2fWhatsNew28#update-constructors
Warning: Constructor for RBSourceListModel needs to be updated to new API
         See http://live.gnome.org/PyGTK_2fWhatsNew28#update-constructors
Warning: Constructor for RBEntryView needs to be updated to new API
         See http://live.gnome.org/PyGTK_2fWhatsNew28#update-constructors
Warning: Constructor for RBLibraryBrowser needs to be updated to new API
         See http://live.gnome.org/PyGTK_2fWhatsNew28#update-constructors
Warning: Constructor for RBSongInfo needs to be updated to new API
         See http://live.gnome.org/PyGTK_2fWhatsNew28#update-constructors

Also, there is a typo in the constructor for RBPropertyView.
Comment 1 Tim Retout 2007-04-22 12:01:53 UTC
Created attachment 86779 [details] [review]
Update constructors to new style

I've only tested EntryView and PropertyView directly, but I did check the rest matched their internal property names.

Marked every property optional, for now.
Comment 2 Jonathan Matthew 2007-08-26 06:04:00 UTC
These have now been fixed by other changes.

I've fixed the remaining warnings (sourcelist and sourcelist-model just had miscapitalisations, URI dialog needed some reworking).