After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 430342 - missing sound names in libsounds/sound-view.c
missing sound names in libsounds/sound-view.c
Status: RESOLVED OBSOLETE
Product: gnome-control-center
Classification: Core
Component: Sound
2.23.x
Other Linux
: High critical
: ---
Assigned To: Rodrigo Moya
Control-Center Maintainers
: 479970 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-04-16 15:41 UTC by Stanislav Brabec
Modified: 2008-07-30 16:40 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24


Attachments
control-center-sound-names.patch (691 bytes, patch)
2007-04-16 15:42 UTC, Stanislav Brabec
needs-work Details | Review

Description Stanislav Brabec 2007-04-16 15:41:02 UTC
Sound list in libsounds/sound-view.c is outdated and does not contains four newly introduced sounds. It caused mixed sound file name / sound name view in the default configuration.
Comment 1 Stanislav Brabec 2007-04-16 15:42:47 UTC
Created attachment 86434 [details] [review]
control-center-sound-names.patch

Sound names patch.
Please find a nice English names and fix them in the patch before applying.
Comment 2 Rodrigo Moya 2007-08-21 12:16:13 UTC
Patch committed
Comment 3 Stanislav Brabec 2007-09-05 17:10:42 UTC
Patch is still not committed. Note that you have to edit names before applying.
Comment 4 Jens Granseuer 2007-09-24 21:01:20 UTC
*** Bug 479970 has been marked as a duplicate of this bug. ***
Comment 5 Claude Paroz 2007-09-24 21:26:03 UTC
Just FYI, you cannot commit this patch for 2.20 unless you ask for a string freeze breakage.
Comment 6 Claude Paroz 2008-07-29 13:59:24 UTC
What's the status of this?
Comment 7 Stanislav Brabec 2008-07-29 14:59:48 UTC
gnome-control-center-2.23.4: Patch still cleanly applies and it is still missing.

Appropriate English sound names were not provided yet as well (see "NAMEME" strings in the patch).
Comment 8 Claude Paroz 2008-07-29 15:20:04 UTC
Is sound naming in the realm of usability guys :-) ?
The sounds can be heard in most modern distros with:
totem /usr/share/sounds/generic.wav (and question.wav, warning.wav, gtk-events/toggled.wav)
Comment 9 Jens Granseuer 2008-07-29 18:37:08 UTC
libsounds is no longer used and pretty much dead. Please let it rest in peace.
Comment 10 Stanislav Brabec 2008-07-30 09:45:53 UTC
To comment #9: Libsounds is still present in gnome-control-center-2.23.4.

And at least in GNOME 2.22 reported problem is still visible in gnome-sound-properties -> Sounds.
Comment 11 Jens Granseuer 2008-07-30 16:23:51 UTC
It's no longer in trunk, though.

2.22 is in maintenance mode which means critical fixes only. This most certainly doesn't qualify.
Comment 12 Stanislav Brabec 2008-07-30 16:40:51 UTC
Well, libsounds support was completely removed from trunk just today.