After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 428689 - [id3tag] add prefer-charset property
[id3tag] add prefer-charset property
Status: RESOLVED DUPLICATE of bug 320188
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal normal
: NONE
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-04-11 16:33 UTC by Young-Ho Cha
Modified: 2007-04-11 21:12 UTC
See Also:
GNOME target: ---
GNOME version: 2.17/2.18


Attachments
add prefer-charset property in id3demux element (11.37 KB, patch)
2007-04-11 16:34 UTC, Young-Ho Cha
none Details | Review
add prefer-charset property in id3demux element (11.44 KB, patch)
2007-04-11 16:52 UTC, Young-Ho Cha
rejected Details | Review

Description Young-Ho Cha 2007-04-11 16:33:14 UTC
Many mp3 media have wrong charset encoding information. (cause damn some win32 apps)

It need to have some workaround for id3demux  element that set charset encoding.
Comment 1 Young-Ho Cha 2007-04-11 16:34:49 UTC
Created attachment 86180 [details] [review]
add prefer-charset property in id3demux element

add prefer-charset property in id3demux element

currently, support id3v2 only.
Comment 2 Tim-Philipp Müller 2007-04-11 16:47:35 UTC
Why is the property needed, can't you already do everything you want by setting one or more of the GST_ID3_TAG_ENCODING, GST_ID3V1_TAG_ENCODING or GST_TAG_ENCODING environment variables?

Comment 3 Young-Ho Cha 2007-04-11 16:52:39 UTC
Created attachment 86184 [details] [review]
add prefer-charset property in id3demux element

add check whether prefer_charset is NULL, in parse_insert_string_field()
Comment 4 Young-Ho Cha 2007-04-11 17:05:36 UTC
GST_ID3_TAG_ENCODING, GST_ID3V1_TAG_ENCODING or
GST_TAG_ENCODING environment variables can affect id3v1 tag only. 

id3demux element are not affected that environment variables.

And I think that need to some interface  to change charset encoding for each file.

Environment variable is not efficient to handle files with different encoding.
Comment 5 Changwoo Ryu 2007-04-11 18:04:14 UTC
I agree with Young-Ho.

People use many different encodings for tags with various (sometimes buggy) programs; they are doing wrong but it's the reality. It's very unconvenient to change the environment variables and rerun application every time when we find different or buggy encodings.
Comment 6 David Schleef 2007-04-11 20:20:29 UTC
I recommend fixing your mp3 files.  Any solution to viewing inconsistently encoded tags requires manual intervention, which means you might as well do it once instead of every time you view the tags.

Having a property is unworkable, since you need to see the tags to guess the encoding, and then change the property to the desired encoding.  At this point, it is too late to get the tags in the new encoding.

It would be nice to have something like a rhythmbox plugin that looks at all tags, and if it sees one that it guesses is in the wrong encoding, it could pop up a dialog that says:

  This file may contain metadata that is encoded incorrectly.  Please
  select the text that appears correct.

And display the tag as several likely encodings.  And then offer to fix the file.

In any case, I don't see this as a gstreamer bug.  It's a bug in your files.  If you want a tool that fixes these for you, gstreamer is probably the wrong place to put the code.
Comment 7 Tim-Philipp Müller 2007-04-11 21:12:29 UTC

*** This bug has been marked as a duplicate of 320188 ***