After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 426349 - cannot word-select in URL bar using double click
cannot word-select in URL bar using double click
Product: epiphany
Classification: Core
Component: [obsolete] URL bar
git master
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Reported: 2007-04-04 20:07 UTC by Loïc Minier
Modified: 2008-09-02 20:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Revert special handling of double click in the LocationEntry (1.23 KB, patch)
2007-04-04 20:07 UTC, Loïc Minier
committed Details | Review

Description Loïc Minier 2007-04-04 20:07:05 UTC

Sam Hocevar reported in Debian bug
   This is a very old behaviour of Epiphany, but I am just trying to
switch from Galeon so I'm discovering it.

   Most GNOME applications, including Galeon, let you select words
by double-clicking them in a text entry. This cannot be done in the
Epiphany URL location because a double click selects the whole area. My
suggestion is to remove this behaviour, because there is no other way
to do quick word selection, while selecting the URL can be done by many
other means:

  * triple-clicking the text in the URL location (usual GNOME way)
  * clicking the icon in the URL location
  * pressing Ctrl-L

   In case you wonder why one would need that: selecting words in the
location bar allows for quick URL hacking. Double click, change word,
press enter, done.

I personally agree with the submitter that it's surprizing to override the behavior of double click.

Comment 1 Loïc Minier 2007-04-04 20:07:49 UTC
Created attachment 85824 [details] [review]
Revert special handling of double click in the LocationEntry
Comment 2 Loïc Minier 2007-04-04 20:12:13 UTC
I checked whether it would be easy to implement this functionality as a python plugin instead, I think it would require:
- exporting EphyLocationEntry objects
- adding and exporting some get_location_entry function on EphyWindow, no idea whether there can be two EphyLocationEntry in a window
- adding and exporting some connect_signal function on EphyLocationEntry
Comment 3 Reinout van Schouwen 2007-04-04 20:20:06 UTC
I think the current double click behaviour is better because most of the time, you want to overwrite the entire URL and not a small part of it. 

But -- see also bug 377772.
Comment 4 Sam Hocevar 2007-04-05 01:46:14 UTC
But there are already 3 ways to overwrite the entire URL (triple click, click on icon, Ctrl-L). How is it better to add a 4th way, remove a feature that cannot be accessed through other means, and become inconsistent with all other GNOME text widgets?
Comment 5 Josselin Mouette 2007-04-11 09:07:03 UTC
Reinout> This behaviour has annoyed me for a long time and I wouldn't have even iamgined it was intentional. Word-selection in an URL is very useful to change a part of the URL, and I'd use it almost every day if it worked.
Comment 6 Cyril Brulebois 2007-09-06 10:32:09 UTC
I'd like to second the application of this patch, too. It applies successfully on current trunk (r7345), with an offset.
Comment 7 Cosimo Cecchi 2007-09-06 11:30:31 UTC
I agree with comment #4, as people which usually use a lot keyboard (like myself) will always use CTRL+L to do the selection and people who use the mouse have other three ways to select the text, with one click, three clicks and click-dragging.
Comment 8 Christian Persch 2007-09-06 20:26:16 UTC
-> 2.22 due to UI freeze.
Comment 9 Cosimo Cecchi 2007-09-26 15:42:42 UTC
Reinout and other interface guys: now that this could be merged to trunk, what shall we do with this?
Comment 10 Reinout van Schouwen 2007-09-26 20:56:07 UTC
It's a difficult tradeoff, but I'm leaning towards letting GNOME text widget consistency trump ease of URL selection. 

Note that the main reason browsers select the whole URL on (double) click the location entry is to make it easy to overwrite. In that respect, bug 118395 is relevant. If we had a broom icon in the text entry (like the evolution search textfield) then would we worry about the number of clicks it takes before a URL is selected?
Comment 11 Josselin Mouette 2007-09-26 21:00:16 UTC
I'm all for the broom. I think it would even be a good idea to replace the useless "go to" icon by this broom.
Comment 12 Reinout van Schouwen 2007-09-26 21:24:37 UTC
Never underestimate the number of people who type a URL, then reach for the mouse to click the Go to button instead of pressing Enter.
Comment 13 Cosimo Cecchi 2007-09-26 22:21:38 UTC
Reinout: I don't think it's a good idea to add a broom icon to the location bar; we already have the clear option from the context menu and if we want we can just make a shortcut for it. Not considering that we have the document icon on the left of the address which selects (and makes easy to overwrite the content of the location bar).
Comment 14 Reinout van Schouwen 2007-09-29 15:32:29 UTC
@Cosimo: those options you mention are there, but they're very unobvious. 
Comment 15 Diego Escalante Urrelo (not reading bugmail) 2008-05-18 23:07:00 UTC
I have come to miss this, I usually double click expecting to get only a word, I used to double click for the whole url though. I changed my mind, I say go :).
Comment 16 Diego Escalante Urrelo (not reading bugmail) 2008-07-29 05:26:49 UTC
Anyone strongly against this patch? I'd like to get it in for 2.24.
Comment 17 Loïc Minier 2008-09-02 20:00:25 UTC
Committed to trunk as r8452 and to gnome-2-24 as r8453.