After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 426281 - gnome-desktop-item-edit doesn't allow fixing input problems after error
gnome-desktop-item-edit doesn't allow fixing input problems after error
Status: RESOLVED FIXED
Product: gnome-panel
Classification: Other
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Panel Maintainers
Panel Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-04-04 16:24 UTC by Ray Strode [halfline]
Modified: 2007-05-12 20:53 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
clear the cached key_file on error (612 bytes, patch)
2007-04-04 16:25 UTC, Ray Strode [halfline]
none Details | Review

Description Ray Strode [halfline] 2007-04-04 16:24:11 UTC
(from https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=233015)

Description of problem:
When creating a new launcher you can confuse the routine by inputting a name larger than 512 characters.  If you enter a large name and press OK, the utility reports that the filename is too long.  If you then select all the text within the name input field, remove it and type in a new smaller name, then press OK.  The same message about the file name being too long is displayed, with the old name.

Version-Release number of selected component (if applicable):
gnome-desktop-item-edit 2.17.91

How reproducible:
Always


Steps to Reproduce:
1. On the desktop within Gnome click the right mouse button.
2. From the menu select create launcher.
3. Enter a name, longer than 512 characters; I inputted 1234567890 several times.
4. Enter a command, I inputted /bin/rm.
5. Press OK.
6. On the message box press OK.
7. Use the mouse and invoke the select all option for the name field.
8. Over type a new smaller name.
9. Press OK.  The same message appears.


Actual Results:
A message box appears, stating filename too long.

Expected Results:
The utility should use the second, shorter name.
Comment 1 Ray Strode [halfline] 2007-04-04 16:25:50 UTC
Created attachment 85809 [details] [review]
clear the cached key_file on error
Comment 2 Vincent Untz 2007-05-12 17:19:46 UTC
Hrm, Ray, I can't reproduce the error here: I don't even have the error in the first place.

But I fail to see why this would happen, since the URI should be re-calculated the second time. If you can reproduce, could you look if the dialog->priv->save_uri is called the second time?
Comment 3 Ray Strode [halfline] 2007-05-12 18:26:42 UTC
So I just tried to reproduce with latest upstream panel.  This reproduces the problem for me:

1) Right click on the desktop in nautilus
2) Choose "Create Launcher" from menu
3) Set command to /bin/true
4) Set name to 

123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890123456890

5) click [OK]
6) press enter at the error dialog
7) change name to 1234567890
8) click [OK]
9) See the same error dialog as from after step 5

I haven't looked at the problem anymore than that today though.
Comment 4 Vincent Untz 2007-05-12 20:53:17 UTC
Oh, I can reproduce now. Weird :-)

I fixed it another way (cropping the filename on disk when it's necessary).