GNOME Bugzilla – Bug 426083
Show cover when available
Last modified: 2018-05-24 10:29:39 UTC
Add some matroska infos for the properties tab in nautilus:
Cover, Attachements, Tags, Chapters, etc.
See the windows shell extension here: http://www.matroska.org/downloads/shellextension/index.html
it depends partially on bug #318748: http://bugzilla.gnome.org/show_bug.cgi?id=318748
I'm afraid that I won't be adding any matroska specific items to the fold, although having covers show up would be nice. Problem is the same as in bug 318748.
Ok, but is there another place for supporting such things (fill a bug against)?
How about the matroska project itself? I'm sure creating such a property window would be straight forward with their libraries.
Showing the cover should be dead-easy to implement. The code and interface are in src/plugins/properties/, and you can use test-properties-page in src/ to test your changes.
You'd need to use BVW_INFO_COVER to get the cover art if it's available.
Created attachment 127626 [details] [review]
patch for this bug
Created attachment 127628 [details]
I'd rather not see "Cover:" at all if the file doesn't provide one. Also, if you're going to resize the cover to 50x50 (why 50x50?) please provide a way to see the full cover when it's clicked on. Finally "Cover:" should be top-aligned, not center-aligned.
Created attachment 128483 [details] [review]
"Cover:" doesn't show if the file doesn't provide one. Cover image now has dynamic size. when cover's clicked on, open new dialog with real size image.
Created attachment 131956 [details] [review]
Half updated patch
Here's (half of) my take on how it should work.
- Small cover (50px max in height and width) in a button with no relief
- When the button is clicked, show a popup with a bigger (or much bigger) image
- Popup goes away when button is released
Popup placement should be centered on the original, so that it looks like we "zoomed" into it. Bit more work needed I'm afraid.
Thanks for working on that.
-- GitLab Migration Automatic Message --
This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.
You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/totem/issues/11.