After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 426044 - [flacenc] broken files when used with oggmux
[flacenc] broken files when used with oggmux
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal normal
: 0.10.6
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-04-03 22:37 UTC by René Stadler
Modified: 2007-05-25 16:04 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description René Stadler 2007-04-03 22:37:38 UTC 
The oggmux element claims to be able to sink "audio/x-flac" data.  However, the  data produced by "flacenc ! oggmux" does not conform to the defined Ogg mapping of FLAC.  Also, no player can make sense of it (including "oggdemux ! flacdec").
Comment 1 Tim-Philipp Müller 2007-05-25 11:26:20 UTC 
This looks more like a flacenc bug, so moving to -good. Flacenc should be adding a "streamheader" field with the right header buffers according to the ogg-flac-mapping to the flac caps and set the BUFFER_IN_CAPS flag on header buffers, so oggmux can create the right headers. Got a patch that needs some cleaning up.
Comment 2 Tim-Philipp Müller 2007-05-25 16:04:31 UTC 
 2007-05-25  Tim-Philipp Müller  <tim at centricular dot net>

        * ext/flac/gstflacenc.c: (gst_flac_enc_init),
        (notgst_value_array_append_buffer),
        (gst_flac_enc_process_stream_headers),
        (gst_flac_enc_write_callback), (gst_flac_enc_chain),
        (gst_flac_enc_change_state):
        * ext/flac/gstflacenc.h:
          Collect headers, add "streamheader" field to output caps and set
          BUFFER_IN_CAPS flag on pushed header buffers. That way oggmux
          produces output according to the official FLAC-to-Ogg mapping
          instead of completely broken files. Fixes #426044.

http://webcvs.freedesktop.org/gstreamer/gst-plugins-good/ext/flac/gstflacenc.c?r1=1.70&r2=1.71
http://webcvs.freedesktop.org/gstreamer/gst-plugins-good/ext/flac/gstflacenc.h?r1=1.17&r2=1.18