After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 424248 - pan hangs around when the queu is empty when downloading nzb from command line
pan hangs around when the queu is empty when downloading nzb from command line
Status: RESOLVED FIXED
Product: Pan
Classification: Other
Component: general
pre-1.0 betas
Other All
: Normal normal
: ---
Assigned To: Charles Kerr
Pan QA Team
Depends on:
Blocks:
 
 
Reported: 2007-03-29 19:50 UTC by Eric Lauriault
Modified: 2007-04-07 04:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Added feature: Quits pan if in non-gui mode and if the queue reaches size 0 (2.35 KB, patch)
2007-04-02 06:52 UTC, Calin Culianu 		committed Details | Review

Description Eric Lauriault 2007-03-29 19:50:03 UTC 
Please describe the problem:
When the queue empties, the process just hangs
around until it gets receives a signal. This behavior can be
observed while downloading using an nzb file from the command line.

Steps to reproduce:
1. start pan with : pan -o somedir --nogui --nzb somefile.nzb
2. 
3. 


Actual results:
Pan starts, downloads the attachement and the process sleeps when the queue empties. 

Expected results:
It should exit cleanly.

Does this happen every time?
yes

Other information:
Comment 1 Calin Culianu 2007-04-02 03:05:14 UTC 
There is a related complaint about this with someone else who wanted to add a --headers command-line facility.  

I know how to fix this -- and am pretty sure Charles' would agree that especially in the --nogui situation it doesn't make sense for the Pan process to stick around.

I will work on a patch for this and submit it here.
Comment 2 Calin Culianu 2007-04-02 06:52:53 UTC 
Created attachment 85684 [details] [review]
Added feature: Quits pan if in non-gui mode and if the queue reaches size 0

This patch makes pan quit when it is done with its tasks in non-gui mode.  Previous to this patch pan would just hang around sleeping forever until it received a signal (because the glib/gtk mainloop was never exited).

Please apply against svn rev 215.

This also addresses someone else's feature request from the mailing list who wanted to be able to DL headers from a script. He also complained about the pan process hanging around after the job is done.
Comment 3 Calin Culianu 2007-04-02 07:05:51 UTC 
PS: Hey sorry Eric for not remembering that it was *you* who complained about this behavior of pan.  

Anyway I am putting this here for completeness: the related bug that also could benefit from this patch is bug #424240.
Comment 4 Eric Lauriault 2007-04-03 01:30:23 UTC 
Works for me. Good job Calin!
Comment 5 Calin Culianu 2007-04-03 01:36:16 UTC 
Great!  Now.. convince Charles to add it to svn.. ;)