After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 423055 - Verify ReplayGain vorbistag processing in libs/tag testsuite
Verify ReplayGain vorbistag processing in libs/tag testsuite
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other All
: Normal enhancement
: 0.10.13
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-03-26 19:57 UTC by René Stadler
Modified: 2007-03-26 22:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
libs/tag.c testsuite addition for ReplayGain tags (2.34 KB, patch)
2007-03-26 20:00 UTC, René Stadler 		committed Details | Review

Description René Stadler 2007-03-26 19:57:18 UTC 
gst-plugins-base/tests/check/libs/tag.c:test_vorbis_tags contains a TODO for the ReplayGain tags.  Attaching a simple patch that implements basic testing for these.
Comment 1 René Stadler 2007-03-26 20:00:15 UTC 
Created attachment 85333 [details] [review]
libs/tag.c testsuite addition for ReplayGain tags

This also removes the TODO comment for the language tag.  I'm suspecting that it is stale, language tag testing seems to be implemented already.
Comment 2 Tim-Philipp Müller 2007-03-26 22:39:08 UTC 
Thanks, committed:

 2007-03-26  Tim-Philipp Müller  <tim at centricular dot net>

        Patch by: René Stadler  <mail at renestadler de>

        * gst-libs/gst/tag/gstvorbistag.c: (gst_tag_to_vorbis_comments):
          When writing out floating-point numbers to vorbis comment tags, always
          use the same character as separator no matter what the current locale is
          (fixes #423051).

        * tests/check/libs/tag.c: (GST_START_TEST):
          Add unit tests for replaygain tags in vorbis comments (closes #423055).