GNOME Bugzilla – Bug 423055
Verify ReplayGain vorbistag processing in libs/tag testsuite
Last modified: 2007-03-26 22:39:08 UTC
gst-plugins-base/tests/check/libs/tag.c:test_vorbis_tags contains a TODO for the ReplayGain tags. Attaching a simple patch that implements basic testing for these.
Created attachment 85333 [details] [review] libs/tag.c testsuite addition for ReplayGain tags This also removes the TODO comment for the language tag. I'm suspecting that it is stale, language tag testing seems to be implemented already.
Thanks, committed: 2007-03-26 Tim-Philipp Müller <tim at centricular dot net> Patch by: René Stadler <mail at renestadler de> * gst-libs/gst/tag/gstvorbistag.c: (gst_tag_to_vorbis_comments): When writing out floating-point numbers to vorbis comment tags, always use the same character as separator no matter what the current locale is (fixes #423051). * tests/check/libs/tag.c: (GST_START_TEST): Add unit tests for replaygain tags in vorbis comments (closes #423055).