GNOME Bugzilla – Bug 422958
Add new icons to support new GDM feature
Last modified: 2007-06-25 20:14:33 UTC
Note GDM enhancement request #360984. This enhancement adds icons to the GDM menu so that when you click on the options menu all the options have a nice looking icon associated with them. The patch in enhancement request #360984 wants to use the following icons from the hicolor theme. I worked with Calum Benson and he said that these names are the appropriate ones to use from the spec. According to Calum these should be included in /usr/share/icons/hicolor/24x24/actions. preferences-desktop-locale user-desktop gnome-logout preferences-desktop-remote-desktop system-restart system-shut-down system-suspend It also uses this icon which is GDM specific, I think since gdmsetup is shipped with GDM: gdm-setup Unfortunately all of these icons are missing from the hicolor theme, so I'm wondering if these icons can be added. So I'm attaching a tarball with these icons. I suspect all of them except for gdm-setup need to be added to the hicolor theme? The tarball also includes the gdm-setup icon in case you tell me that it makes the most sense to include this in hicolor directly rather than having GDM install it. Also, working with Calum, it seems that the /usr/share/icons/hicolor/index.theme file doesn't support the 22x22 directory. I'm also attaching an updated index.theme file that fixes this problem. Calum grabbed this fixed file from Ubuntu and using it seems to fix the problem. Shouldn't this updated index.theme file go upstream?
Created attachment 85314 [details] tarball with the images. bzip2 tarball containing the new icons
Created attachment 85315 [details] index.theme file updated index.theme file
Oh, one thing isn't quite right about my previous description. The gnome-logout icon does seem to already exist in hicolor, and isn't in the tarball. This icon isn't really needed since this icon only shows up when you run gdmlogin or gdmgreeter in debug mode. However, it would be nice to have such an icon just for people who run in debug mode. Also I assume the gdm-setup icon should go into the apps subdirectory rather than actions. Is this correct?
No, they aren't in hicolor. This is gnome-icon-theme, not hicolor-icon-theme. Perhaps another feasible request for GDM is that it should allow one to specify an icon theme in the GDM theme files, and fall back to the GNOME theme, rather than no theme at all. Something like: if (theme->icon_theme) gtk_icon_theme_set_custom_theme (gtk_icon_theme_get_default (), theme->icon_theme); else gtk_icon_theme_set_custom_theme (gtk_icon_theme_get_default (), "gnome"); If you really think you need the icons to be provided in "hicolor", then look at shipping them in your own $pkgdatadir/icons/hicolor directory, as described in http://live.gnome.org/ThemableAppIcons . As for gdm-setup, please install it from the gdm package into the system hicolor/$size/apps directory as appropriate, matching the name of the binary it is for, as described in the Icon Naming Specification. As for gnome-icon-theme, we will not be installing any icons into the hicolor theme, where only app icons are meant to be installed by applications, not other themes. The latest version of hicolor-icon-theme does support the 22x22 directories, and the contexts from the Icon Naming Specification. Please make sure you have the latest version of that.
Thanks for your response. I'd like a bit of clarification, though. Since GDM is used in non-GNOME environments such as KDE, does it make sense to depend on icons in gnome-icon-theme, or to depend on a specific theme to be installed? I assumed these icons would need to be in hicolor in order to be generally available. Considering this, do you think it makes more sense for the icons to live in hicolor or shipping them in GDM's own $pkgdaatadir/icons/hicolor directory as you suggest? Or do you think I should file an enhancement request to hicolor-icon-theme and see what they say? Sorry for filing this bug in the wrong area. Thanks for the help.
Whether or not they would be installed in hicolor, gnome, or whatever other name, they would still be installed by gnome-icon-theme. The hicolor-icon-theme package does not contain any icons. It ships a directory structure and an index.theme, that is all. And we cannot install icons from gnome-icon-theme into it, as it can cause conflicts if others try to install icons of the same name, and also sets the precident that other themes can install icons into other theme directories, which is just horribly bad. If you really want to avoid depending on gnome-icon-theme, you can copy the icons out into the gdm source tree, and install them into GDM's own $pkgdatadir/icons/hicolor, as described in http://live.gnome.org/ThemableAppIcons . However, I think it would probably be better to require gnome-icon-theme, use it as a fallback, and allow the GDM theme to specify an icon theme to use. This way, for those people on KDE, they could have a GDM theme that uses Crystal, Oxygen, or whatever, for the icons, to be consistent with the desktop.