Bug 421920 – Clicking Library or Linux makes gimmie crash

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 421920 - Clicking Library or Linux makes gimmie crash


Summary:	Clicking Library or Linux makes gimmie crash


Status:	RESOLVED DUPLICATE of bug 421620

Product:	gimmie
Classification:	Deprecated
Component:	general
Version:	0.2.x
Hardware:	Other All

Importance:	Normal critical
Target Milestone:	---
Assigned To:	Gimmie Maintainers
QA Contact:	Gimmie Maintainers

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2007-03-23 15:27 UTC by kristoffer paro
Modified:	2007-03-25 23:02 UTC

See Also:
GNOME target:	---
GNOME version:	---

Description kristoffer paro 2007-03-23 15:27:15 UTC

Steps to reproduce:
1. Click Library or Linux button while gimmie is running
2. 
3. 


Stack trace:
Memory status: size: 0 vsize: 0 resident: 0 share: 0 rss: 0 rss_rlim: 0
CPU usage: start_time: 0 rtime: 0 utime: 0 stime: 0 cutime:0 cstime: 0 timeout: 0 it_real_value: 0 frequency: 0

Traceback (most recent call last):

+ Trace 121476

File "/usr/local/lib/python2.4/site-packages/gimmie/gimmie_gui.py", line 386 in do_clicked
```
self.topic_win = self.topic.get_topic_window()
```
File "/usr/local/lib/python2.4/site-packages/gimmie/gimmie_base.py", line 377 in get_topic_window
```
self.topic_window = TopicWindow(self)
```
File "/usr/local/lib/python2.4/site-packages/gimmie/gimmie_topicwin.py", line 1134 in __init__
```
self.find_first_button()
```
File "/usr/local/lib/python2.4/site-packages/gimmie/gimmie_topicwin.py", line 1026 in find_first_button
```
filtered = self._filter_items_num_days_ago(items, zoom)
```
File "/usr/local/lib/python2.4/site-packages/gimmie/gimmie_topicwin.py", line 1050 in _filter_items_num_days_ago
```
return [x for x in items if self._filter_compare(x, days_ago)]
```
File "/usr/local/lib/python2.4/site-packages/gimmie/gimmie_base.py", line 219 in get_items
```
for i in self.get_items_uncached():
```
File "/usr/local/lib/python2.4/site-packages/gimmie/gimmie_recent.py", line 77 in get_items_uncached
```
for item in source.get_items_uncached():
```
File "/usr/local/lib/python2.4/site-packages/gimmie/gimmie_computer.py", line 217 in get_items_uncached
```
yield DriveItem(drive)
```
File "/usr/local/lib/python2.4/site-packages/gimmie/gimmie_computer.py", line 106 in __init__
```
raise ValueError, "Cannot find URI to open for drive '%s'" % drive
```

ValueError: Cannot find URI to open for drive '<gnomevfs.Drive object (GnomeVFSDrive) at 0xb26bc89c>'


Other information:
I studied at the relevant code lines in gimmie_computer.py and did the following test using command line python:

>>> for drive in vol_monitor.get_connected_drives():
...     drive.get_device_path()
... 
'/dev/hda'

get_connected_drives() returns /dev/hda (my DVD-drive) as the only connected device, although my hard drive is /dev/sda. And when I didn't have a disc in the drive, get_mounted_volumes() for that drive returned an empty list, which resulted in the error condition (else statement at line 105).

Putting a CD in the drive removed the problem.

I run gimmie 0.2.6 on Ubuntu Edgy

Comment 1 kristoffer paro 2007-03-23 16:04:31 UTC

Further research:

In gimmie_computer.py line 216 we have:

for drive in self.vol_monitor.get_connected_drives():
    yield DriveItem(drive)

And at line 96:

uri = drive.get_activation_uri()
if not uri:
    for volume in drive.get_mounted_volumes():
        if volume.is_user_visible():
            # FIXME: Using the first volume URI for a device is
            #        broken. There could be multiple, though I don't
            #        know under what circumstances this would happen.
            uri = volume.get_activation_uri()
            break
    else:
        raise ValueError, "Cannot find URI to open for drive '%s'" % drive

Correct me if I'm wrong, but doesn't this mean that Gimmie expects every drive to have at least one mounted, visible volume? I mean, one could of course have an unpartitioned hard drive installed. Wouldn't that result in the same error as well?

Comment 2 Tony Tsui 2007-03-25 23:02:54 UTC

Thanks for taking the time to report this bug.
This particular bug has already been reported into our bug tracking system, but we are happy to tell you that the problem has already been fixed. It should be solved in the next software version. You may want to check for a software upgrade.


*** This bug has been marked as a duplicate of 421620 ***