GNOME Bugzilla – Bug 420649
cleanup use of ve_i18n_get_language_list
Last modified: 2007-03-21 13:32:45 UTC
stumbled in this cleanup by chance: vicious-extensions has a ve_i18n_get_language_list which used to be split between gnome and non-gnome. However glib has go g_get_language_names for a while so we should just use that and delete a whole bunch of code. This is even more true when we realize that ve_i18n_get_language_list these days is implemented in terms of g_get_language_names for the gnome case! Patch follows, however note that it is only *compile* tested (I have no idea how to run a self compiled gdm)
Created attachment 84993 [details] [review] gdm patch
Created attachment 84994 [details] [review] v-e patch
glancing at ve-misc.h #if GLIB_CHECK_VERSION(2,3,1) #define ve_setenv g_setenv #define ve_unsetenv g_unsetenv #else int ve_setenv (const char *name, const char *value, gboolean overwrite); void ve_unsetenv (const char *name); #endif could be cleaned up too throughout the source, since according to configure.ac: GLIB_REQUIRED=2.8.0
I'm almost done removing VE BTW. See bug #355425.
William, I assume that your fix has already gotten rid of this problem? I notice that gdm-common-config.c is using g_get_language_names() already, so I assume this is done? Could you verify and close this bug if this issue is already addressed with your patch?
Paolo thanks for your patch. I was able to incorportate it into the patch on bug #355425. I appreciate your help. *** This bug has been marked as a duplicate of 355425 ***