After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 419571 - bacon-volume simplification
bacon-volume simplification
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: general
unspecified
Other Linux
: Normal trivial
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2007-03-18 00:14 UTC by Christian Persch
Modified: 2007-05-11 09:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (6.80 KB, patch)
2007-03-18 00:15 UTC, Christian Persch 		none Details | Review

Description Christian Persch 2007-03-18 00:14:24 UTC 
IMHO there's no need to cache all 4 icons in BaconVolume, since there'll only be one displayed at each time, and it doesn't change often enough to warrant the caching anyway. Attached patch removes the icons caching.
Comment 1 Christian Persch 2007-03-18 00:15:50 UTC 
Created attachment 84808 [details] [review]
patch
Comment 2 Bastien Nocera 2007-03-19 00:18:06 UTC 
This is what the new code in bug #415775. Wouldn't be better to wait and kill bacon-volume instead?
Comment 3 Christian Persch 2007-03-30 21:11:48 UTC 
I just want to flush local changes to clean up my tree  :)
Also I don't see a great chance for BaconVolume being accepted in gtk.
Comment 4 Bastien Nocera 2007-05-11 09:47:52 UTC 
2007-05-11  Bastien Nocera  <hadess@hadess.net>

        * src/bacon-volume.c: (bacon_volume_button_class_init),
        (bacon_volume_button_init), (bacon_volume_button_dispose),
        (bacon_volume_button_new), (bacon_volume_button_update_icon):
        * src/bacon-volume.h: Merge Christian Persch <chpe@svn.gnome.org> 's
        simplifications, set the tooltip on startup, otherwise we wouldn't
        have any tooltip when the volume starts at 0 (Closes: #419571)