After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 419006 - Refactor acroread.py to remove global methods
Refactor acroread.py to remove global methods
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Orca Maintainers
Orca Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-03-16 15:46 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2007-03-16 16:51 UTC
See Also:
GNOME target: ---
GNOME version: 2.17/2.18

Attachments
patch with all refactoring completed (18.65 KB, patch)
2007-03-16 15:50 UTC, Joanmarie Diggs (IRC: joanie) 		committed Details | Review

Description Joanmarie Diggs (IRC: joanie) 2007-03-16 15:46:34 UTC 
As Will pointed out (http://bugzilla.gnome.org/show_bug.cgi?id=395548#c36), there are a number of global methods that need to be moved into the acroread.Script class.
Comment 1 Joanmarie Diggs (IRC: joanie) 2007-03-16 15:50:24 UTC 
Created attachment 84722 [details] [review]
patch with all refactoring completed

Will, everything is moved.  I tested it in several documents, including looking at:

* General document reading
* SayAll (such as it is)
* The Find toolbar
* Handling of tagged and untagged tables

Seems to work and no tracebacks.
Comment 2 Willie Walker 2007-03-16 16:31:00 UTC 
Looks good.  Please commit and closed as FIXED.
Comment 3 Joanmarie Diggs (IRC: joanie) 2007-03-16 16:51:32 UTC 
Done.  Thanks!!