After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 418918 - Switch to GRegex
Switch to GRegex
Status: RESOLVED FIXED
Product: vte
Classification: Core
Component: general
0.15.x
Other Linux
: Normal normal
: ---
Assigned To: VTE Maintainers
VTE Maintainers
Depends on: 398862
Blocks:
 
 
Reported: 2007-03-16 11:09 UTC by Chris Wilson
Modified: 2008-06-24 18:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[PATCH] Prepare for gregex by moving consolidating the code to clear a vte_match_regex in one place only. (5.86 KB, patch)
2008-05-29 11:50 UTC, Christian Persch
accepted-commit_now Details | Review
[PATCH] Add support for GRegex. Only either gregex or the old regex stuff must be used, not both at the same time. Bug #418918. (11.80 KB, patch)
2008-05-29 11:50 UTC, Christian Persch
accepted-commit_now Details | Review

Description Chris Wilson 2007-03-16 11:09:57 UTC
Instead of offering to choose between multiple incompatible regular expression parsers, solely support GRegex.

Since this means changing the default regex over to a PCRE based library it will actually be an API break for most users and only suitable for the next major soname revision.
Comment 1 Christian Persch 2008-05-29 11:50:16 UTC
I implemented this. Since comment 0 says that we cannot just change to GRegex by default for now, I made it so you can use either old regex or gregex, but not mix the two.
Comment 2 Christian Persch 2008-05-29 11:50:46 UTC
Created attachment 111724 [details] [review]
[PATCH] Prepare for gregex by moving consolidating the code to clear a vte_match_regex in one place only.

 src/reflect.c     |   27 +++++++++++++++++++++++++++
 src/vte-private.h |   15 ++++++++++++++-
 src/vte.c         |   47 +++++++++++++++++++++++++----------------------
 src/vte.h         |    5 ++++-
 4 files changed, 70 insertions(+), 24 deletions(-)
Comment 3 Christian Persch 2008-05-29 11:50:49 UTC
Created attachment 111725 [details] [review]
[PATCH] Add support for GRegex. Only either gregex or the old regex stuff must be used, not both at the same time. Bug #418918.

 src/vte-private.h |    1 +
 src/vte.c         |  316 ++++++++++++++++++++++++++++++++++++++++++++++++++++-
 2 files changed, 313 insertions(+), 4 deletions(-)
Comment 4 Behdad Esfahbod 2008-05-29 17:11:59 UTC
So, something for vte 1.0
Comment 5 Christian Persch 2008-05-30 18:31:54 UTC
Do you mean this should wait until 1.0, or wait until 1.0 to remove the old regex but put gregex in now?
Comment 6 Behdad Esfahbod 2008-05-30 18:35:47 UTC
(In reply to comment #5)
> Do you mean this should wait until 1.0, or wait until 1.0 to remove the old
> regex but put gregex in now?

The latter.  Feel free to do whatever you want as long as you don't break people's running applications :).

You touched it, now you own it ;)
Comment 7 Christian Persch 2008-06-23 14:29:53 UTC
So that means ok to commit, right? :)
Comment 8 Behdad Esfahbod 2008-06-23 14:37:44 UTC
Yes.
Comment 9 Christian Persch 2008-06-24 18:12:10 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.