Bug 418673 - gtk_recent_manager_add_item
gtk_recent_manager_add_item
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Class: GtkRecent
2.10.x
Other All
: Normal minor
: ---
Assigned To: gtk-bugs
Emmanuele Bassi (:ebassi)
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2007-03-15 18:50 UTC by Morten Welinder
Modified: 2007-03-15 20:01 UTC (History)
0 users

See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Morten Welinder 2007-03-15 18:50:51 UTC 
1. add_error is not used.

2. Using g_slice_new looks weird here.  A stack variable would do it.
Comment 1 Emmanuele Bassi (:ebassi) 2007-03-15 20:01:24 UTC 
fixed in trunk, and also backported to the stable branch.

2007-03-15  Emmanuele Bassi  <ebassi@gnome.org>

	* gtk/gtkrecentmanager.c (gtk_recent_manager_add_item): Remove
	unused GError; do not allocate GtkRecentData and use a variable
	on the stack. (#418673, Morten Welinder)
Note You need to log in before you can comment on or make changes to this bug.