After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 418383 - Codec auto-download not working when movie has external subtitles
Codec auto-download not working when movie has external subtitles
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: GStreamer backend
2.18.x
Other Linux
: Normal normal
: ---
Assigned To: Maintainer alias for GStreamer component of Totem
Maintainer alias for GStreamer component of Totem
Depends on:
Blocks:
 
 
Reported: 2007-03-14 22:23 UTC by Sebastien Bacher
Modified: 2007-04-03 12:43 UTC
See Also:
GNOME target: ---
GNOME version: 2.17/2.18

Attachments
possible minimal fix (857 bytes, patch)
2007-03-21 14:47 UTC, Tim-Philipp Müller 		accepted-commit_now Details | Review
better fix / work-around (1.76 KB, patch)
2007-04-03 12:42 UTC, Tim-Philipp Müller 		committed Details | Review

Description Sebastien Bacher 2007-03-14 22:23:16 UTC 
The bug has been opened on https://launchpad.net/ubuntu/+source/totem/+bug/89302

"Binary package hint: totem-gstreamer

Ubuntu 7.04 daily build (2nd Mar 2007)

When doubleclicking on some movie with proprietary codecs, a dialog with auto-download codec feature appears. When doubleclicking on the same movie, but with external subtitles present (named eg. movie_name.srt), only this error dialog appears:

An error occurred
GstPlayBin: Only a subtitle stream was detected. Either you are loading a subtitle file or some other type of text file, or the media file was not recognized.

This is a bug, totem should ignore the subtitles and offer to the user the same possibility to auto-download codecs, as it does with movies without subtitles. Because (at least at my country) most of all movies comes with subtitles, this renders the whole auto-download-codec feature only half-working...

ProblemType: Bug
Date: Fri Mar 2 20:54:05 2007
DistroRelease: Ubuntu 7.04
Uname: Linux ubuntu 2.6.20-9-generic #2 SMP Mon Feb 26 03:01:44 UTC 2007 i686 GNU/Linux"
Comment 1 Tim-Philipp Müller 2007-03-21 14:47:10 UTC 
Created attachment 85045 [details] [review]
possible minimal fix

Minimal fix (this should probably be fixed in playbin instead, but I am not sure yet what the best way to go about this is; quick-fixing it in totem seems best for now).
Comment 2 Bastien Nocera 2007-03-26 01:04:28 UTC 
Sebastien, does this fix your problem?
Comment 3 Sebastien Bacher 2007-03-27 09:57:56 UTC 
The patch applied to totem 2.18.0 works fine on my Ubuntu desktop
Comment 4 Tim-Philipp Müller 2007-04-03 12:42:35 UTC 
Created attachment 85759 [details] [review]
better fix / work-around
Comment 5 Tim-Philipp Müller 2007-04-03 12:43:22 UTC 
Committed slightly better version of the patch to trunk and 2.18 branch:

 2007-04-02  Tim-Philipp Müller  <tim at centricular dot net>

        * src/backend/bacon-video-widget-gst-0.10.c:
        (bvw_check_missing_plugins_error):
          Make the missing-plugins stuff work in the case where we have
          a subtitles streams but no video stream (presumably because we are
          missing the appropriate video decoder). This should probably be
          handled better in playbin itself, but for now we'll work around it.
          (Closes: #418383)