After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 417999 - Don't use deprecated GTK+ symbols
Don't use deprecated GTK+ symbols
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: Mailer
1.10.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
: 489073 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-03-13 20:55 UTC by Matthew Barnes
Modified: 2007-11-22 07:29 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch for evolution-data-server (34.50 KB, patch)
2007-03-13 21:02 UTC, Matthew Barnes
none Details | Review
Proposed patch for libical (906 bytes, patch)
2007-03-13 21:03 UTC, Matthew Barnes
committed Details | Review
Proposed patch for evolution (37.62 KB, patch)
2007-03-13 21:09 UTC, Matthew Barnes
none Details | Review
Revised patch for evolution-data-server (34.28 KB, patch)
2007-04-02 14:32 UTC, Matthew Barnes
none Details | Review
Revised patch for evolution-data-server (19.02 KB, patch)
2007-04-04 15:23 UTC, Matthew Barnes
none Details | Review
Corrected patch for evolution-data-server (34.16 KB, patch)
2007-04-09 16:21 UTC, Matthew Barnes
none Details | Review
Revised patch (19.08 KB, patch)
2007-06-12 02:02 UTC, Matthew Barnes
none Details | Review
Sync'ed with latest Subversion source (34.22 KB, patch)
2007-08-08 15:43 UTC, Matthew Barnes
none Details | Review
Revised patch for Evolution (42.25 KB, patch)
2007-08-20 20:52 UTC, Matthew Barnes
committed Details | Review
Revised patch for Evolution-Data-Server (34.17 KB, patch)
2007-08-20 20:55 UTC, Matthew Barnes
committed Details | Review
proposed evo patch (1.11 KB, patch)
2007-10-26 09:50 UTC, Milan Crha
committed Details | Review

Description Matthew Barnes 2007-03-13 20:55:12 UTC
I did some general code-cleanup work on evolution-data-server to kick off the next development cycle.  I'm splitting the changes into managable chunks, and filing separate bugs for each.  Here's the first one.

   - Migrate off deprecated GTK+ functions.

   - Upstream some more implicit function declaration fixes that were lurking
     in an old Red Hat patch (circa 1.3.x).  A couple of these are for libical.

   - Deprecate ESourceOptionMenu and migrate to a new ESourceComboBox widget.
     ESourceOptionMenu inherits from GtkOptionMenu, which is deprecated.
     ESourceComboBox inherits from GtkComboBox, which replaces GtkOptionMenu.

   - Document ESourceComboBox.
Comment 1 Matthew Barnes 2007-03-13 21:02:08 UTC
Created attachment 84533 [details] [review]
Proposed patch for evolution-data-server
Comment 2 Matthew Barnes 2007-03-13 21:03:23 UTC
Created attachment 84534 [details] [review]
Proposed patch for libical

Fixes a couple implicit function declarations.
Comment 3 Matthew Barnes 2007-03-13 21:09:23 UTC
Created attachment 84535 [details] [review]
Proposed patch for evolution

Uses ESourceComboBox instead of ESourceOptionMenu.
Comment 4 Matthew Barnes 2007-04-02 14:32:36 UTC
Created attachment 85701 [details] [review]
Revised patch for evolution-data-server

A Fedora user was kind enough to alert me to a stupid mistake I made in the ESourceComboBox widget [1].  Here's a revised patch.

[1] http://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234760
Comment 5 Matthew Barnes 2007-04-04 15:23:59 UTC
Created attachment 85807 [details] [review]
Revised patch for evolution-data-server

This revision fixes another ESourceComboBox bug:

Don't activate a row on creation.  The caller hasn't had a chance to connect to the "changed" signal yet, and if he tries to activate the already-active row, the "changed" signal won't be emitted.
Comment 6 Matthew Barnes 2007-04-09 16:21:03 UTC
Created attachment 86053 [details] [review]
Corrected patch for evolution-data-server

It would probably help to actually include the new widget in the patch...
Comment 7 Srinivasa Ragavan 2007-06-10 18:51:08 UTC
--- libedataserverui/e-name-selector-dialog.h	(revision 7689)
+++ libedataserverui/e-name-selector-dialog.h	(working copy)
@@ -58,7 +58,6 @@ struct _ENameSelectorDialog {
 	/* Private */
 
 	EBook              *pending_book;
-	ESourceList        *source_list;
 	ENameSelectorModel *name_selector_model;
 	GtkTreeModelSort   *contact_sort;

This breaks ABI. I didn't review it fully but too tired to review a huge patch :(
Comment 8 Matthew Barnes 2007-06-11 02:12:17 UTC
Yeah, it's too bad private member variables are tied to the ABI.
/me makes a mental note to push for using g_type_class_add_private().

I see three ways to address your concern:

1) Leave it there as cruft.
2) Replace it with something like "gpointer placeholder".
3) Yeah, so we broke ABI.  It's for an unstable development version.

I suppose (2) is probably the best option.
Comment 9 Jeffrey Stedfast 2007-06-11 03:55:35 UTC
it's kinda preferable to just do what every other gnome app does which is to do this:


struct _EWidgetFu {
   GtkWidget parent_object

   struct _EWidgetFuPrivate *priv;
};



and then define struct _EWidgetFuPrivate internal to the .c file

using the g_type_class_*_private() stuff is annoying to use when debugging, much simpler to just use a priv variable. Plus it'd be more consistant with a lot of other evo code (imho, better to keep consistent)
Comment 10 Srinivasa Ragavan 2007-06-11 06:46:21 UTC
I think we should go the way fejj said. But I dont want to do it now. 

Either convert it to a gpointer or leave it as it is (Causes any error?). 
Comment 11 Matthew Barnes 2007-06-12 01:53:30 UTC
I agree.  That might be a good "evolution-love" task for someone to start on after we finish with the compiler warning cleanup.

Using both a "priv" pointer and g_type_class_add_private() would give you the best of both worlds.  GObject would allocate and deallocate the private structure for you (and more efficiently), and the "priv" pointer would make the private data easily reachable in a debugger.
Comment 12 Matthew Barnes 2007-06-12 02:02:43 UTC
Created attachment 89786 [details] [review]
Revised patch

This revision fixes the ABI break mentioned in comment #7 by replacing the ESourceList pointer with a gpointer placeholder.
Comment 13 Matthew Barnes 2007-08-08 15:43:28 UTC
Created attachment 93287 [details] [review]
Sync'ed with latest Subversion source
Comment 14 Srinivasa Ragavan 2007-08-09 06:52:35 UTC
I would like to target it for 2.14.
Comment 15 Matthew Barnes 2007-08-20 20:52:56 UTC
Created attachment 94019 [details] [review]
Revised patch for Evolution

This revision fixes some bugs in the BBDB plugin.  See bug #447591 for details.
Comment 16 Matthew Barnes 2007-08-20 20:55:22 UTC
Created attachment 94020 [details] [review]
Revised patch for Evolution-Data-Server

Some minor refactoring to ESourceComboBox to help catch similar bugs in the future.
Comment 17 Matthew Barnes 2007-08-21 15:12:13 UTC
If the patches here are accepted we should consider applying Milan's work in bug #460649 which adds the ESource's color to the combo box.
Comment 18 Suman Manjunath 2007-09-11 16:06:27 UTC
cc'ing myself..
Comment 19 Matthew Barnes 2007-09-18 14:36:50 UTC
Srini: Just a friendly ping so you don't forget about this.

The bug is blocking some follow up work I'd like to do for 2.14/2.22.
Comment 20 Srinivasa Ragavan 2007-09-18 20:23:11 UTC
Matthew, I wont forget for sure. Just relaxing by staying idle for this week. (Idle = revamping my setups, machines, etc) Will take it up from next week on
Comment 21 Matthew Barnes 2007-10-22 18:53:04 UTC
Srini agreed to let me commit this in time for 2.21.1.  It's been in Fedora for some time now and I believe all the major bugs have been shaken out.

libical (revision 626)
evolution (revision 34408).
evolution-data-server (revision 8138)
Comment 22 Milan Crha 2007-10-26 09:46:55 UTC
There still left one place with "source_changed" signal in Evolution.
Comment 23 Milan Crha 2007-10-26 09:50:20 UTC
Created attachment 97898 [details] [review]
proposed evo patch

for evolution;

... and here's the patch for that forgotten place.
Comment 24 Matthew Barnes 2007-10-26 11:35:58 UTC
Good catch, Milan.  Please commit to trunk.
Comment 25 Milan Crha 2007-10-26 13:18:59 UTC
Committed to trunk. Committed revision 34436.
Comment 26 Akhil Laddha 2007-11-22 07:29:34 UTC
*** Bug 489073 has been marked as a duplicate of this bug. ***