After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 417168 - While using the crop tool, pressing Shift to toggle 'Use ratio' do not work well.
While using the crop tool, pressing Shift to toggle 'Use ratio' do not work w...
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: Tools
git master
Other Linux
: Normal normal
: 2.4
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2007-03-11 18:21 UTC by Zas
Modified: 2007-07-08 13:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Block-Options-Notify-On-Shift.patch (1000 bytes, patch)
2007-07-08 13:24 UTC, Martin Nordholts 		committed Details | Review

Description Zas 2007-03-11 18:21:34 UTC 
Pressing Shift do not immediatly toggle the checkbox.

If 'use ratio' is checked with ie. 16:9 value, pressing
Shift cause ratio to be ignored until you release the
mouse button, leading to 16:9 ratio instead of free ratio (due to Shift).
Comment 1 Martin Nordholts 2007-07-02 19:27:55 UTC 
I am working on a rewrite of the rectangle code that is supposed to fix this.

If you want to follow patch progress, please CC yourself to bug #398188.
Comment 2 Martin Nordholts 2007-07-08 13:24:33 UTC 
Created attachment 91431 [details] [review]
Block-Options-Notify-On-Shift.patch

This had nothing to do with the cleanup in gimp_rectangle_tool_motion, so it makes more sense to commit a fix for this separately.
Comment 3 Martin Nordholts 2007-07-08 13:41:02 UTC 
Fixed in trunk, revision 22896.

2007-07-08  Martin Nordholts  <martinn@svn.gnome.org>

	* app/tools/gimprectangletool.c
	(gimp_rectangle_tool_active_modifier_key): Block
	gimp_rectangle_tool_options_notify when changing fixed-aspect
	through the shift key. Fixes bug #417168.