After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 417014 - Invalid / incomplete catagories field in several gnome-games .desktop files
Invalid / incomplete catagories field in several gnome-games .desktop files
Status: RESOLVED FIXED
Product: gnome-games-superseded
Classification: Deprecated
Component: gnibbles
2.17.x
Other All
: Normal minor
: gnome-2-20
Assigned To: GNOME Games maintainers
GNOME Games maintainers
Depends on:
Blocks:
 
 
Reported: 2007-03-11 08:16 UTC by Hans de Goede
Modified: 2007-06-20 19:18 UTC
See Also:
GNOME target: ---
GNOME version: 2.17/2.18


Attachments
Posible fix (2.56 KB, patch)
2007-06-19 19:55 UTC, Kim Christensen
committed Details | Review

Description Hans de Goede 2007-03-11 08:16:55 UTC
Hi,

Short intro I'm a fedora contributer who is active in the games Special Interest Group (SIG), see:
http://fedoraproject.org/wiki/Extras/SIGs/Games
http://fedoraproject.org/wiki/HansdeGoede

As Games SIG, we are so successful at packaging games, that the
Applications->Games menu can become rather cluttered up. To fix this "problem"
I've created a package called games-menus. Which creates a number of submenus
under the Games menus based on the additional categories a .desktop file with as
main category Game may have, see:
http://standards.freedesktop.org/menu-spec/latest/apa.html

However some gnome-games games do not show up in the submenus (instead they stay
in the "main" Games menu) or show up in a strange submenu. This happens because
of missing or invalid additional categories in the .desktop files for these games.

To reproduce (on fedora-6 or devel):
yum install games-menus

Goto your application menu and then:
* Iagno shows up directly under Games, should be under Games->Board Games
  Fix: add BoardGame to the categories

* Sudoku shows up directly under Games, should be under Games->Logic & Puzzles
  Fix: add LogicGame to the categories

* Tali shows up directly under Games, should be under Games->Card Games
  Fix: add CardGame to the categories

* Nibbles (aka snake) shows up under Games->Arcade, I have _never_ seen snake
  in an Arcade, should be under Games->Logic & Puzzles
  Fix: remove ArcadeGame from and add LogicGame to the categories


Other information:
I initially filed this in Fedora's bugzilla but Ray Strode, RH's gnome maintainer said he found it a valid bug, but wanted to see it fixed upstream so here I'm for the original bug see:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=231720
Comment 1 Kim Christensen 2007-06-19 19:55:51 UTC
Created attachment 90294 [details] [review]
Posible fix
Comment 2 Hans de Goede 2007-06-19 20:33:31 UTC
Fix looks good, except that I don't see LogicGame being added to the soduko desktop, has this already been fixeD?
Comment 3 Thomas Andersen 2007-06-20 00:23:07 UTC
Sudoku was already fixed in SVN.
Looks good, patch committed to trunk. Thanks Kim!
Comment 4 Kim Christensen 2007-06-20 19:18:14 UTC
Yes, as Thomas Andersen points out the soduko was already fixed in SVN. I attemted to post that comment along with patch, but for some reason only the patch was posted.