GNOME Bugzilla – Bug 416889
Broken build, due to dependence on x11.pc
Last modified: 2007-03-14 09:18:50 UTC
The patch in bug 409278 broke the build for distros that do not have x11.pc. Loic was incorrect in his claims in bug 409278 comment 3 about x11.pc coming with Xorg; as an example, xorg 6.8.2 (comes with Fedora 3/RHEL 4) does not have x11.pc.
Created attachment 84397 [details] [review] Fallback to old-style X11 detection Hmm sorry, I meant 7.0 => x11.pc, and not Xorg => x11.pc, and this was indeed not very accurate in my original comment. I forgot providing a version falling back on AC_PATH_XTRA like I did for gnome-panel, libgnomekbd, gail, and evolution, so I'm attaching this patch now which will try the pkg-config modules for x11 but also for sm + ice, and fall back to old-style AC_PATH_XTRA detection. I added an AC_MSG_ERROR to keep failing in configure when X11 isn't found, but only for non-win32 builds. I also added the libs to the libgnomeui.la object, not to LIBGNOMEUI_LIBS, as this seemed more flexible. In general, I tried to match the existing SM tests. I have tested this patch both with pkg-config modules and with old-style detection. @Elijah, can you confirm this patch fixes the problem for you?
Works for me, and it looks like Kjartan has already applied the patch. Thanks for the quick response guys!
Looks like that change is breaking gnome-session, with libgnomeui 2.18.0 tarball, from the config.h on Ubuntu (xorg 7.2): "/* #undef HAVE_LIBSM */", the required Build-Depends are installed
Created attachment 84508 [details] [review] Close the pkg_check_modules test at the correct place Here's a patch closing the pkg_check_modules at the correct place. Apologies for this stupid typo.
Commited. Thanks for the patches.
*** Bug 417718 has been marked as a duplicate of this bug. ***