After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 416861 - It isn't possible to change the desktop font color
It isn't possible to change the desktop font color
Status: RESOLVED DUPLICATE of bug 317764
Product: nautilus
Classification: Core
Component: Desktop
0.x.x [obsolete]
Other All
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-03-10 18:29 UTC by Luigi Maselli
Modified: 2010-08-01 10:40 UTC
See Also:
GNOME target: ---
GNOME version: 2.17/2.18


Attachments
It permits to the users to choose the desktop font color (1.07 KB, patch)
2007-03-10 18:36 UTC, Luigi Maselli
none Details | Review
a little bit better (1.21 KB, patch)
2007-03-11 14:07 UTC, Luigi Maselli
none Details | Review

Description Luigi Maselli 2007-03-10 18:29:09 UTC
Please describe the problem:
If you have a bright desktop, it's hard to read with the default font color.
I tried to change the default value with a theme but it is harcoded.

Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Luigi Maselli 2007-03-10 18:36:24 UTC
Created attachment 84354 [details] [review]
It permits to the users to choose the desktop font color

I tried to solve this problem with the user-defined colors as you can see here http://www.grigio.org/10_passi_diventare_un_potenziale_programmatore_open_source
Comment 2 Luigi Maselli 2007-03-11 14:03:50 UTC
Comment on attachment 84354 [details] [review]
It permits to the users to choose the desktop font color

Index: libnautilus-private/nautilus-icon-container.c
===================================================================
--- libnautilus-private/nautilus-icon-container.c	(revisione 12793)
+++ libnautilus-private/nautilus-icon-container.c	(copia locale)
@@ -7250,13 +7250,18 @@
 				  LABEL_INFO_COLOR, 
 				  eel_gdk_color_is_dark (&widget->style->base[GTK_STATE_NORMAL]) ? light_info_value : dark_info_value);
 	} else {
-		if (container->details->use_drop_shadows || eel_background_is_dark (background)) {
-			setup_gc_with_fg (container, LABEL_COLOR, 0xEFEFEF);
+		if (eel_background_is_dark (background)
+		    && !eel_gdk_color_is_dark (&widget->style->base[GTK_STATE_NORMAL])) {	  
+			setup_gc_with_fg (container, LABEL_COLOR, 
+					  eel_gdk_color_to_rgb (&widget->style->text[GTK_STATE_ACTIVE]));
+
 			setup_gc_with_fg (container, 
 					  LABEL_INFO_COLOR, 
 					  light_info_value);
 		} else { /* converse */
-			setup_gc_with_fg (container, LABEL_COLOR, 0x000000);
+			container->details->use_drop_shadows = FALSE;
+			setup_gc_with_fg (container, LABEL_COLOR, 
+					  eel_gdk_color_to_rgb (&widget->style->text[GTK_STATE_NORMAL]));
 			setup_gc_with_fg (container, 
 					  LABEL_INFO_COLOR, 
 					  dark_info_value);
Comment 3 Luigi Maselli 2007-03-11 14:07:08 UTC
Created attachment 84380 [details] [review]
a little bit better
Comment 4 Luigi Maselli 2007-03-19 17:35:32 UTC
comments?
Comment 5 André Klapper 2007-09-15 10:28:56 UTC
luigi, please do some patch nagging and ask for a review on nautilus-list@gnome.org
Comment 6 Marcus Carlson 2010-07-31 21:32:50 UTC
Also related to #317764, mark as DUPLICATE?
Comment 7 Cosimo Cecchi 2010-08-01 10:40:30 UTC
Thanks for the bug report. This particular bug has already been reported into our bug tracking system, but please feel free to report any further bugs you find.

*** This bug has been marked as a duplicate of bug 317764 ***