GNOME Bugzilla – Bug 416861
It isn't possible to change the desktop font color
Last modified: 2010-08-01 10:40:30 UTC
Please describe the problem: If you have a bright desktop, it's hard to read with the default font color. I tried to change the default value with a theme but it is harcoded. Steps to reproduce: Actual results: Expected results: Does this happen every time? Other information:
Created attachment 84354 [details] [review] It permits to the users to choose the desktop font color I tried to solve this problem with the user-defined colors as you can see here http://www.grigio.org/10_passi_diventare_un_potenziale_programmatore_open_source
Comment on attachment 84354 [details] [review] It permits to the users to choose the desktop font color Index: libnautilus-private/nautilus-icon-container.c =================================================================== --- libnautilus-private/nautilus-icon-container.c (revisione 12793) +++ libnautilus-private/nautilus-icon-container.c (copia locale) @@ -7250,13 +7250,18 @@ LABEL_INFO_COLOR, eel_gdk_color_is_dark (&widget->style->base[GTK_STATE_NORMAL]) ? light_info_value : dark_info_value); } else { - if (container->details->use_drop_shadows || eel_background_is_dark (background)) { - setup_gc_with_fg (container, LABEL_COLOR, 0xEFEFEF); + if (eel_background_is_dark (background) + && !eel_gdk_color_is_dark (&widget->style->base[GTK_STATE_NORMAL])) { + setup_gc_with_fg (container, LABEL_COLOR, + eel_gdk_color_to_rgb (&widget->style->text[GTK_STATE_ACTIVE])); + setup_gc_with_fg (container, LABEL_INFO_COLOR, light_info_value); } else { /* converse */ - setup_gc_with_fg (container, LABEL_COLOR, 0x000000); + container->details->use_drop_shadows = FALSE; + setup_gc_with_fg (container, LABEL_COLOR, + eel_gdk_color_to_rgb (&widget->style->text[GTK_STATE_NORMAL])); setup_gc_with_fg (container, LABEL_INFO_COLOR, dark_info_value);
Created attachment 84380 [details] [review] a little bit better
comments?
luigi, please do some patch nagging and ask for a review on nautilus-list@gnome.org
Also related to #317764, mark as DUPLICATE?
Thanks for the bug report. This particular bug has already been reported into our bug tracking system, but please feel free to report any further bugs you find. *** This bug has been marked as a duplicate of bug 317764 ***