After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 414864 - rhythmbox crash in metadata_cb
rhythmbox crash in metadata_cb
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: Plugins (other)
0.9.8
Other Linux
: Normal critical
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
: 467602 480888 482228 495373 509104 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-03-05 11:09 UTC by Sebastien Bacher
Modified: 2008-01-13 09:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
probable fix (702 bytes, patch)
2007-04-21 07:12 UTC, Jonathan Matthew 		committed Details | Review

Description Sebastien Bacher 2007-03-05 11:09:34 UTC 
That bug has been described on https://launchpad.net/bugs/88058

"Binary package hint: rhythmbox

Ejected Music CD while Rhythmbox was starting.
...
Package: rhythmbox 0.9.8-0ubuntu2
..."

Debug backtrace for the crash:

+ Trace 115973

  • #0 metadata_cb
    at rb-audiocd-source.c line 523
  • #1 metadata_marshal_VOID__POINTER_POINTER
    at sj-metadata-marshal.c line 59
  • #2 IA__g_closure_invoke
    at gclosure.c line 490
  • #3 signal_emit_unlocked_R
    at gsignal.c line 2440
  • #4 IA__g_signal_emit_valist
    at gsignal.c line 2199
  • #5 IA__g_signal_emit_by_name
    at gsignal.c line 2267
  • #6 fire_signal_idle
    at sj-metadata-musicbrainz.c line 265
  • #7 g_idle_dispatch
    at gmain.c line 3928
  • #8 IA__g_main_context_dispatch
    at gmain.c line 2045
  • #9 g_main_context_iterate
    at gmain.c line 2677
  • #10 IA__g_main_loop_run
    at gmain.c line 2881
  • #11 IA__gtk_main
    at gtkmain.c line 1168 






Comment 1


Jonathan Matthew





          2007-04-21 07:12:50 UTC
        



Created attachment 86727 [details] [review]
probable fix

It looks like metadata_cb gets called with albums == NULL; this just adds a check for that case.  I haven't actually tested that it fixes anything.






Comment 2


James "Doc" Livingston





          2007-04-21 07:26:11 UTC
        



Looks good to me.






Comment 3


Jonathan Matthew





          2007-04-21 08:49:08 UTC
        



Committed to trunk and stable.






Comment 4


palfrey





          2007-08-23 10:31:00 UTC
        



*** Bug 467602 has been marked as a duplicate of this bug. ***






Comment 5


Jonathan Matthew





          2007-09-27 11:38:37 UTC
        



*** Bug 480888 has been marked as a duplicate of this bug. ***






Comment 6


Jonathan Matthew





          2007-10-01 21:50:26 UTC
        



*** Bug 482228 has been marked as a duplicate of this bug. ***






Comment 7


Jonathan Matthew





          2007-11-10 13:26:58 UTC
        



*** Bug 495373 has been marked as a duplicate of this bug. ***






Comment 8


Jonathan Matthew





          2008-01-13 09:12:15 UTC
        



*** Bug 509104 has been marked as a duplicate of this bug. ***