GNOME Bugzilla – Bug 414657
Linked headings should be announced as both heading and link
Last modified: 2008-07-22 19:27:32 UTC
On the Orca list, Hermann said: > I would suggest that a link that's also a heading should be announced > as both, no matter which caret mode and which kind of navigation. > The announcement should be "heading link" and then the content. Currently, if a heading is 100% a heading, we speak "heading" after the text. If it is a link at the beginning followed by a heading, we say "link" after the linked bit and "heading" after the rest. If the heading is 100% link, however, we just say "link" after the text. For a sample, please see this test case: http://svn.gnome.org/svn/orca/trunk/test/html/simpleheader.html Whether or not it says "heading link" and then the content versus content followed by "heading link" might need some additional consideration and discussion.
Right now, we have some logic (Gecko.py:getContainingLink) to handle situations such as when an image is contained inside a link. I wonder if we also need a similar method to get the containing object for a link. Or, more generally, should we have logic in speechgenerator.py and braillegenerator.py that detects something really is of multiple roles and present those multiple roles? We have speechgenerator.py._getSpeechForObjectRole which is inconsistently used (we generally call rolenames.getSpeechForRolename instead). But, there might be opportunity to modify this method to determine compound role names. We'd probably also need some new stuff in braillegenerator.py to do the same thing for braille.
Mike, I didn't see where compound roles such as this are addressed in the spec. What should we speak and braille in the following cases: 1. The entire item is both heading and link, for instance a heading level 2 which is a link called "Chapter 3" 2. The entire item is a heading with links inside of it, such as: a. "Read Chapter 3" (where it's all a heading level 2 and "Chapter 3" is also a link) b. "Chapter 3 is worth reading" (where it's all a heading level 2 and "Chapter 3" is also a link) c. "You should read Chapter 3 and Chapter 4 because they're good." (where it's all a heading level 2 and both "Chapter 3" and "Chapter 4" are links) Thanks!
I think the best thing to do here is: for the example where the whole link is the heading just speak link followed by heading and level at the end. For the cases where links are contained in a heading speak link after each piece that is a link and then the heading information at the end.
Created attachment 88354 [details] test case/sample document
Created attachment 88355 [details] [review] proposed patch This patch handles links and other things (e.g. images) that are children of headings both for speech and braille. MIke please give this a test. Thanks!
So far this patch is looking good but I want to find more sites to test it on before I call it good for sure.
I think we're OK to call this one good.
Thanks Mike. Will: Please review. Thanks!
Patch committed. Changing status to pending.
(In reply to comment #9) > Patch committed. Changing status to pending. Just to follow up - Joanie and I went over this off line. So there really *was* a review. :-)
Okay for me to close this one?
Sounds good
Thanks! Closing as FIXED.