GNOME Bugzilla – Bug 414539
[API] Support more GST_TAG*_SORTNAME and remove MusicBrainz-specificity
Last modified: 2007-10-25 15:13:49 UTC
Currently GST_TAG_MUSICBRAINZ_SORTNAME (which sorts the track artist) is specific to MusicBrainz, but needn't be. It should probably be renamed to something generic like GST_TAG_ARTIST_SORTNAME. Further, because some tagging backends support it, other tags should be added, so the list might be (with corresponding id3v2 tag as an example): GST_TAG_ARTIST_SORTNAME TSOP GST_TAG_ALBUM_SORTNAME TSOA GST_TAG_TRACK_SORTNAME TSOT GST_TAG_ALBUMARTIST_SORTNAME (none in id3v2) http://developer.kde.org/~wheeler/taglib/api/classTagLib_1_1ID3v2_1_1TextIdentificationFrame.html
See also: http://musicbrainz.org/doc/MusicBrainzTag
Please make sure to use $TAG_SORTNAME where $TAG is that tag that is sorted. So it should be GST_TITLE_SORTNAME
> Please make sure to use $TAG_SORTNAME where $TAG is that tag that is sorted. > So it should be GST_TITLE_SORTNAME Why? That seems slightly inconsistent with the current GST_TAG_* namespace we're using for all other tags at the moment.
my bad, typo: s/GST_TITLE_SORTNAME/GST_TAG_TITLE_SORTNAME/ The rest of the argument should still hold. :)
A sample file (ie. first 100kB or so) with those tags would be helpful.
Committed this: -core (0.10.15): 2007-10-24 Tim-Philipp Müller <tim at centricular dot net> * docs/gst/gstreamer-sections.txt: * gst/gsttaglist.c: * gst/gsttaglist.h: API: add GST_TAG_ARTIST_SORTNAME API: add GST_TAG_ALBUM_SORTNAME API: add GST_TAG_TITLE_SORTNAME Add tag variants for sorting (#414539). -base (0.10.15): 2007-10-25 Tim-Philipp Müller <tim at centricular dot net> * gst-libs/gst/tag/tag.h: (GST_TAG_MUSICBRAINZ_SORTNAME): * gst-libs/gst/tag/tags.c: Deprecate GST_TAG_MUSICBRAINZ_SORTNAME, replaced by the newly-added GST_TAG_ARTIST_SORTNAME (in an API and ABI compatible way). * gst-libs/gst/tag/gstid3tag.c: (tag_matches): Map ID3v2 TSOP, TSOA and TSOT frames to new SORTNAME tags (#414539). * gst-libs/gst/tag/gstvorbistag.c: (tag_matches), (gst_tag_to_vorbis_comments): Map new SORTNAME tags (these tags aren't even semi-official, so I'm just mapping everything I found in the wild) (#414539). -good (0.10.7): 2007-10-25 Tim-Philipp Müller <tim at centricular dot net> * ext/taglib/gstid3v2mux.cc (add_funcs): Map new SORTNAME tags to ID3v2 TSOP, TSOA and TSOT frames (#414539). I'm reluctant to add ALBUMARTIST_SORTNAME - if there's not even an ID3v2 tag for it, it can't be used very widely ... consider it WONTFIX for now (or provide evidence of this being used and needed).