GNOME Bugzilla – Bug 414138
Fails to build when srcdir != builddir
Last modified: 2007-04-09 00:50:45 UTC
Hi, gnome-system-tools fails to build out of tree with: Making all in e-map make[4]: entrant dans le répertoire « /home/lool/jhbuild-gnome-2.18/build/gnome-system-tools/src/time/e-map » ( /home/lool/jhbuild-gnome-2.18/prefix/bin/glib-genmarshal e-map-marshal.list --header > e-map-marshal.tmp \ && mv e-map-marshal.tmp e-map-marshal.h ) \ || ( rm -f e-map-marshal.tmp && exit 1 ) (process:1360): GLib-Genmarshal-WARNING **: failed to open "e-map-marshal.list": No such file or directory make[4]: *** [e-map-marshal.h] Erreur 1 make[4]: quittant le répertoire « /home/lool/jhbuild-gnome-2.18/build/gnome-system-tools/src/time/e-map » This is due to the reference to the e-map-marshal.list missing a $(srcdir). I'll attach a patch which fixes and also adds an e-map-marshal.list dependency to the .c (like for the .h). Bye,
Created attachment 83787 [details] [review] Search for e-map-marshal.list in $(srcdir)/; add a dependency on e-map-marshal.list to e-map-marshal.c
Created attachment 83788 [details] [review] Search for e-map-marshal.list in $(srcdir)/; add a dependency on e-map-marshal.list to e-map-marshal.c (take 2) Here's a cleaner patch which will correctly refer to the same .list file in the dependencies as the one it generates; it also uses $< to avoid repeating the path.
Created attachment 83792 [details] [review] Search for e-map-marshal.list in $(srcdir)/; add a dependency on e-map-marshal.list to e-map-marshal.c (take 3) Hmm, using "$<" is actually enough to solve the bug, no need to add $(srcdir) thanks to the VPATH; hence, here's an even simpler patch. (Sorry for the spam.)
Thanks for the patch, it has been committed to trunk/2.18 :)