After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 413925 - Updated icon names from the Icon Naming Spec
Updated icon names from the Icon Naming Spec
Status: RESOLVED FIXED
Product: gnome-volume-manager
Classification: Deprecated
Component: general
2.17.x
Other Linux
: Normal normal
: ---
Assigned To: Gnome volume manager maintainers
Gnome volume manager maintainers
Depends on:
Blocks:
 
 
Reported: 2007-03-02 17:38 UTC by Rodney Dawes
Modified: 2007-10-13 17:21 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch to update icon names used in gvm for the naming spec (3.60 KB, patch)
2007-03-02 17:38 UTC, Rodney Dawes
none Details | Review
updated Rodney's patch to apply cleaner to more recent versions of g-v-m (3.66 KB, patch)
2007-04-16 16:14 UTC, Jeffrey Stedfast
accepted-commit_after_freeze Details | Review
Updated patch to use new icons in gnome-icon-theme (6.17 KB, patch)
2007-06-27 20:04 UTC, Luca Ferretti
none Details | Review

Description Rodney Dawes 2007-03-02 17:38:21 UTC
GVM should use some updated names from the naming spec. The attached patch fixes those icons which are feasible to change, at the moment.
Comment 1 Rodney Dawes 2007-03-02 17:38:54 UTC
Created attachment 83741 [details] [review]
Patch to update icon names used in gvm for the naming spec
Comment 2 Jeffrey Stedfast 2007-04-16 16:14:40 UTC
Created attachment 86437 [details] [review]
updated Rodney's patch to apply cleaner to more recent versions of g-v-m

All this patch does is update the patch to apply cleaner (line offsets, etc)

Only reason I'm not committing is because the icons changed (except scanner, which ironically did not show up before) are missing in the UI after this patch in OpenSuSE 10.2 (probably because it doesn't have an up-to-date tango icon package... or, perhaps, I just don't have it installed?)

other than that, patch looks fine and that this patch should probably get applied as soon as I figure otu what the deal with the icons is. I'm sure the next SuSE release will contain the needed tango icons.
Comment 3 Luca Ferretti 2007-06-27 20:04:49 UTC
Created attachment 90780 [details] [review]
Updated patch to use new icons in gnome-icon-theme

In the last days a lot of new icons have landed in gnome-icon-theme. The only missing ones are:

  * camera-video (jimmac is working on it, soon available, see 409612)
  * specific icons (video dvd, audio cd, palm, pocketpc)

About specific icon: g-v-m should use icon fallback available in GTK+ trunk (i.e. should declare in code to use, for example, "pda-pocketpc" named icon; if this icon is not available in current theme, but generic "pda" is available, then use "pda". See 396901 or GtkIconTHeme docs).

By now this patch use the standard and generic names (media-optical and pda)
Comment 4 Jeffrey Stedfast 2007-10-13 17:21:04 UTC
fixed in svn