After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 413130 - charpick doesn't handle transparent background
charpick doesn't handle transparent background
Status: RESOLVED FIXED
Product: gnome-applets
Classification: Other
Component: charpick
unspecified
Other Linux
: Normal trivial
: ---
Assigned To: gnome-applets Maintainers
gnome-applets Maintainers
: 419673 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-02-28 17:09 UTC by Luca Cavalli
Modified: 2008-02-09 21:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
charpick-trasparent.patch (1.89 KB, patch)
2007-02-28 17:10 UTC, Luca Cavalli 		none Details | Review
Handle background-changes of the panel (387 bytes, patch)
2008-02-08 15:27 UTC, Florian Mutter 		none Details | Review

Description Luca Cavalli 2007-02-28 17:09:37 UTC 
Charpick doesn't handle transparent background. Requested at FOSDEM 2007 (see point 75. here http://live.gnome.org/Brussels2007/StickyNotes ).
Comment 1 Luca Cavalli 2007-02-28 17:10:45 UTC 
Created attachment 83552 [details] [review]
charpick-trasparent.patch

Code taken from trash applet.
Comment 2 Luca Cavalli 2007-05-19 16:50:46 UTC 
The wiki page is now moved to:

http://live.gnome.org/Brussels2007/LoveWall
Comment 3 Andreas Köhler 2007-05-20 18:24:52 UTC 
*** Bug 419673 has been marked as a duplicate of this bug. ***
Comment 4 Hendrik Richter 2007-08-15 11:14:12 UTC 
Patch looks good to me. I just applied it to SVN TRUNK and it works. Can someone of the maintainers please review and commit this patch?
Comment 5 Canek Peláez Valdés 2008-02-01 00:07:52 UTC 
I can confirm that the patch applies and works just fine with gnome-applets-2.21.4.
Comment 6 Florian Mutter 2008-02-08 15:27:39 UTC 
Created attachment 104714 [details] [review]
Handle background-changes of the panel

Here is a little shorter patch i wrote.
Comment 7 Luca Cavalli 2008-02-08 18:53:28 UTC 
A lot better, thanks Florian.
Now we can only hope that a maintainer will note this little nice patch within the next couple of years.

BTW, you forgot the space between the function name and the round bracket and after the GTK_WIDGET macro.
Comment 8 Callum McKenzie 2008-02-09 21:19:41 UTC 
That patch has the right line of code, but its in the wrong place. Instead I've put the call to panel_applet_set_background_widget inside the charpicker_applet_fill function. The result has been committed to SVN head and should be in gnome-applets 2.21.91.

Thanks.