After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 412541 - New Socket check does not work.
New Socket check does not work.
Status: RESOLVED DUPLICATE of bug 408309
Product: fast-user-switch-applet
Classification: Deprecated
Component: Applet
2.20.x
Other Linux
: Normal normal
: ---
Assigned To: Fast User Switch Applet Maintainer
Fast User Switch Applet Maintainer
Depends on:
Blocks: 408309
 
 
Reported: 2007-02-27 06:35 UTC by Daniel Holbach
Modified: 2007-12-15 04:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
small fix (839 bytes, patch)
2007-02-27 06:36 UTC, Daniel Holbach 		rejected Details | Review

Description Daniel Holbach 2007-02-27 06:35:18 UTC 
After finding the NEW socket, the new socket test overrides the value of file_stat and claims to not find a socket at all.

Patch attached.
Comment 1 Daniel Holbach 2007-02-27 06:36:09 UTC 
Created attachment 83445 [details] [review]
small fix
Comment 2 Craig Keogh 2007-12-14 03:29:46 UTC 
I just hit this bug. It causes fusa to crash on startup on my machine.
The if else loop is wrong. An alternate patch to Daniel Holbach is add one word 'else', see below. Can we have this fixed please.

Index: src/gdm-queue.c
===================================================================
--- src/gdm-queue.c     (revision 479)
+++ src/gdm-queue.c     (working copy)
@@ -237,7 +237,7 @@
 
         if (stat (GDM_NEW_SOCKET_FILENAME, &file_stat) == 0)
           strcpy (addr.sun_path, GDM_NEW_SOCKET_FILENAME);
-        if (stat (GDM_OLD_SOCKET_FILENAME, &file_stat) == 0)
+        else if (stat (GDM_OLD_SOCKET_FILENAME, &file_stat) == 0)
           strcpy (addr.sun_path, GDM_OLD_SOCKET_FILENAME);
         else
           g_error ("Can't find gdm socket!");
Comment 3 Thomas Thurman 2007-12-14 03:58:18 UTC 
Yes-- will commit tomorrow or this weekend, or anyone with commit rights may.
Comment 4 Thomas Thurman 2007-12-15 03:53:36 UTC 
Okay, checked in. Taking Craig's solution (and crediting him) merely because it's simpler and meets coding standards better. Sorry to everyone affected by this; it was most irresponsible of me to overlook this bug for so long.
Comment 5 Thomas Thurman 2007-12-15 04:39:06 UTC 
This is a dupe of an older bug, so I'm marking it as such.
Comment 6 Thomas Thurman 2007-12-15 04:39:25 UTC 

*** This bug has been marked as a duplicate of 408309 ***