After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 412033 - Find previous when pressing Shift+Return in search field
Find previous when pressing Shift+Return in search field
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Interface
git master
Other Linux
: Normal enhancement
: gnome-2-20
Assigned To: Epiphany Maintainers
Marco Pesenti Gritti
Depends on:
Blocks:
 
 
Reported: 2007-02-25 21:32 UTC by Robin Stocker
Modified: 2007-05-04 20:28 UTC
See Also:
GNOME target: ---
GNOME version: 2.15/2.16

Attachments
Make Shift+Return find the previous result. (560 bytes, patch)
2007-02-25 21:34 UTC, Robin Stocker 		committed Details | Review

Description Robin Stocker 2007-02-25 21:32:19 UTC 
When searching a web page, one enters the search term and then presses the return key to step through the results. I usually do the stepping rather fast and sometimes miss a result and want to go back.

With the current behaviour, I have to take the mouse and press the button "Find Previous" or press Shift+Ctrl+G.

It would be very nice if I could press Shift+Return to go to the previous result, just like I can press Return to go to the next result. Currently, pressing Shift+Return in the search field does nothing, so it wouldn't conflict with existing behaviour. Additionally, Shift+Return is the same shortcut as in Firefox.

The suggested patch adds 8 lines to the entry_key_press_event_cb function in src/ephy-find-toolbar.c. Please consider applying.
Comment 1 Robin Stocker 2007-02-25 21:34:47 UTC 
Created attachment 83329 [details] [review]
Make Shift+Return find the previous result.
Comment 2 Diego Escalante Urrelo (not reading bugmail) 2007-03-06 03:28:58 UTC 
Cool idea :). What do others think?
Comment 3 Christian Persch 2007-03-12 12:25:28 UTC 
Moving to 2.20 target due to feature and UI freeze for 2.18.
Comment 4 Christian Persch 2007-03-12 13:01:09 UTC 
Yes, let's take this one.
Comment 5 Reinout van Schouwen 2007-03-20 19:52:10 UTC 
Robin, can you commit your patch to trunk?
Comment 6 Robin Stocker 2007-03-22 00:19:44 UTC 
(In reply to comment #5)
> Robin, can you commit your patch to trunk?
> 

No I can't, because I don't have any commit rights. I'm just a regular user..
Comment 7 Robin Stocker 2007-04-25 19:45:02 UTC 
I've re-tested the patch with the current trunk and it still applies and works perfectly. So, can someone please commit the patch?
Comment 8 Reinout van Schouwen 2007-04-27 07:09:29 UTC 
Diego?
Comment 9 Diego Escalante Urrelo (not reading bugmail) 2007-05-04 19:48:10 UTC 
Reinout? :)
Comment 10 Diego Escalante Urrelo (not reading bugmail) 2007-05-04 19:59:24 UTC 
2007-05-04  Diego Escalante Urrelo <diegoe@gnome.org>

        * src/ephy-find-toolbar.c:

        Make Shift+Return find previous when searching.
        Patch by Robin Stocker.

        Fixes #412033


Committed to trunk. Leaving open because I'm not sure if this should go to 2-18.
Comment 11 Baptiste Mille-Mathias 2007-05-04 20:24:47 UTC 
Hi Diego,
 
such addition would be considered as a feature addition, and it breaks the policy.
So I'm sorry, I don't think it could go in 2.18.

Regards,
Comment 12 Diego Escalante Urrelo (not reading bugmail) 2007-05-04 20:28:39 UTC 
Then let's close this...


Thanks for the patch Robin!