After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 411705 - Listview Column Header Volume Icon Does Nothing
Listview Column Header Volume Icon Does Nothing
Status: RESOLVED OBSOLETE
Product: rhythmbox
Classification: Other
Component: User Interface
0.9.8
Other Linux
: Normal enhancement
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-02-24 22:04 UTC by Sebastien Bacher
Modified: 2018-05-24 12:22 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Just to the playing or paused song when the 'state' column is selected (2.08 KB, patch)
2009-01-07 08:06 UTC, John Daiker
needs-work Details | Review

Description Sebastien Bacher 2007-02-24 22:04:37 UTC
That bug has been opened on https://launchpad.net/bugs/87553

"Binary package hint: rhythmbox

In Rhythmbox version 0.9.6 on Ubuntu Edgy, currently the volume icon in the header of the list view does nothing. It is located in the same area as headers that do have an action associated with them (sorting fields). It seems to me that the volume icon in the header should bring up the currently playing song. This should have the same effect as pressing Ctrl + J."
Comment 1 Jonathan Matthew 2008-11-15 09:25:19 UTC
I'm not sure this is a great idea as it'd be inconsistent with normal tree view columns, but it shouldn't be hard for someone interested to try it out.

This would be done in rb-entry-view.c, connecting a handler to the 'clicked' signal from the tree view column.  The handler would just call rb_entry_view_scroll_to_entry() if view->priv->playing_state is RB_ENTRY_VIEW_PLAYING or RB_ENTRY_VIEW_PAUSED, passing in the view->priv->playing entry.
Comment 2 John Daiker 2009-01-07 08:06:36 UTC
Created attachment 125906 [details] [review]
Just to the playing or paused song when the 'state' column is selected

My best effort as per comment #2.
Comment 3 Jonathan Matthew 2009-02-24 08:13:16 UTC
Cosmetic things about the patch:
- adds spurious declaration of rb_entry_view_column_clicked_cb
- unnecessary whitespace change
- the debug message in rb_entry_view_state_clicked_cb is wrong
- the if statement in rb_entry_view_state_clicked_cb is probably a bit complicated; should probably check if the playing entry is in the view, then switch based on playing state

And its effects:
- The edges of the icon in the playing state column header are obscured
- When the playing state column is the most recently clicked column, it gets the selection highlight, but it shouldn't.

I'm not sure if either of the last two issues can be fixed, but I don't think it would be a good idea to commit this as is.  There are already two (or more) ways to cause the view to jump to the playing entry, and this adds some confusing visual aspects.

Comment 4 GNOME Infrastructure Team 2018-05-24 12:22:39 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/rhythmbox/issues/328.