Created attachment 83255 [details] [review]
Here's a patch based on the podcast cover searcher

This works for me, mostly.  Although it might be better done in a similar way to the jamendo plugin because it sometimes tries to use the results from the Amazon search.

Created attachment 83313 [details] [review]
Patches magnatune plugin, instead of artdisplay

This works well for me.  One issue, that is a problem with Magnatune really, is that frequently it won't find album art for particular tracks.  For example, if you try to play "Saturn Blues" by Beat Under Control, no art will appear.  Upon closer inspection it appears that the song_info.xml specifies the artist as "Beatundercontrol", here is the relevant XML snippet:

<Track>
    <artist>Beatundercontrol</artist>
    <artistphoto>http://magnatune.com//artists/img/beatunder1.jpg</artistphoto>
    <artistdesc>jazz/dub intense electro funk</artistdesc>
    <albumname>The Introduction</albumname>
    <trackname>Saturn Blues</trackname>
    <tracknum>6</tracknum>
    <year>2003</year>
    <mp3genre>Electronic</mp3genre>
    <magnatunegenres>Electronica,Rock</magnatunegenres>
    <license>http://creativecommons.org/licenses/by-nc-sa/1.0/</license>
    <seconds>365</seconds>
    <url>http://he3.magnatune.com/all/06-Saturn%20Blues-Beatundercontrol.mp3</ur
l>
    <mp3lofi>http://he3.magnatune.com/all/06-Saturn%20Blues-Beatundercontrol-lof
i.mp3</mp3lofi>
    <buy>https://magnatune.com/artists/buy_album?artist=Beat+Under+Control&amp;a
lbum=The+Introduction&amp;genre=Electronica</buy>
    <home>http://magnatune.com/artists/beatundercontrol</home>
    <launchdate>2004-04-27</launchdate>
    <albumsku>beatunder-intro</albumsku>
</Track>

This means the plugin based on the format:

http://www.magnatune.com/music/%s/%s/cover.jpg

will construct the URL:

http://www.magnatune.com/music/Beatundercontrol/The%20Introduction/cover.jpg

but no art is located there, because the full artist name is used instead, and the art is actually located at:

http://www.magnatune.com/music/Beat%20Under%20Control/The%20Introduction/cover.jpg

I'm not sure how to get around this, because magnatune supplies inconsistent spacing and abbreviations for the artist names in the XML vs. on the site.  It might be that the information in the <buy> tag is more reliable to extract for the actual artist/album information, so maybe you could parse the artist and album from:

<buy>https://magnatune.com/artists/buy_album?artist=Beat+Under+Control&amp;a
lbum=The+Introduction&amp;genre=Electronica</buy>

if no art can be found in the standard location.  Either way, we should probably report this to magnatune so that they can make their XML song info file more consistent.

(In reply to comment #4)
> I'm not sure how to get around this, because magnatune supplies inconsistent
> spacing and abbreviations for the artist names in the XML vs. on the site.

That's the reason I didn't do this myself when the Jamendo plugin did.

> Either way, we should
> probably report this to magnatune so that they can make their XML song info
> file more consistent.

Will do.

Committed to svn, thanks.

Is there much we can do to handle the inconsistent artist name formatting, besides asking Magnatune to fix it?

(In reply to comment #6)

> Is there much we can do to handle the inconsistent artist name formatting,
> besides asking Magnatune to fix it?

Probably not, I did send an e-mail to Magnatune, but have not heard anything back.  I did also try to post to their forum:

http://forum.magnatune.com/read/?forum=magnatune-discussion

but my post never appeared. 

Actually it might be possible to parse the <bug> tag to extract the artist and album as outlined in comment #4, because it tends to be a more reliable form of the artist and album name than the XML tags.

(In reply to comment #7)
> (In reply to comment #6)
> 
> > Is there much we can do to handle the inconsistent artist name formatting,
> > besides asking Magnatune to fix it?
> 
> Probably not, I did send an e-mail to Magnatune, but have not heard anything
> back.  I did also try to post to their forum:

I sent an email, and John said he'd include a tag for the artwork. It doesn't seem to have appeared yet though.

Created attachment 84089 [details] [review]
Use cover_small tag for art location

The catalog has been updated, so now we don't need to guess the URL of the album art.

Adam -- Your patch isn't applying for .  Have you updated your local copy recently? (James committed the second patch I posted).

Created attachment 84114 [details] [review]
second try

Alright, I updated to the latest svn. Does the patch apply now?

Yep.  I'm even getting artwork for compilation albums now. Cool!

Committed to svn trunk. Thanks.