GNOME Bugzilla – Bug 410681
Support more musicbrainz tags in tags and rhythmdb
Last modified: 2007-03-14 08:56:05 UTC
sound-juicer support a much larger range of musicbrainz tags than rhythmbox, such as sort order and release and artist ID. rhythmbox currently only supports the trackid. Supporting more tags (both when ripping files and in rhythmdb) will allow more clever things to be done in plugins, for example, getting album art from musicbrainz.
Will try and work up a patch.
Sort order would also be very nice, as it will allow us to ignore "the" when sorting.
Created attachment 83874 [details] [review] Add support for more musicbrainz tags This patch adds support for the following GST tags: GST_TAG_MUSICBRAINZ_ARTISTID GST_TAG_MUSICBRAINZ_ALBUMID GST_TAG_MUSICBRAINZ_ALBUMARTISTID GST_TAG_MUSICBRAINZ_SORTNAME in the rhythmdb backend, as well as support in the audiocd plugin to write the tags to the files. Currently the sortname needs the patch on bug # to be applied to gstreamer to work for mp3 files, but it will still work without that patch, it just won't set the sortname. This is just the start, I plan to add support for all GST_TAG_*_MUSICBRAINZ_* tags such as GST_TAG_CDDA_MUSICBRAINZ_DISCID, but this patch can be applied to trunk now, and those updates be added later.
The gstreamer bug mentioned above is bug #414496, which I'm marking as a dependent bug, but isn't a blocker, per se.
Created attachment 83875 [details] [review] Remove extraneous bit that came from another locally applied patch
Created attachment 83876 [details] [review] Oops, and another
Full list of tags for different formats tagging formats: id3, vorbis etc. is here: http://musicbrainz.org/doc/MusicBrainzTag Not all of these tags are supported in gstreamer yet.
Patch looks fine to commit to me, although I'd possibly add a trailing comma to the change in metadata/rb-metadata-common.c - so that you don't have to modify the last line when adding new stuff.
(In reply to comment #8) > Patch looks fine to commit to me, although I'd possibly add a trailing comma to > the change in metadata/rb-metadata-common.c - so that you don't have to modify > the last line when adding new stuff. Done and committed to SVN trunk.