After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 410517 - When item modified today, display modification time, not "Today"
When item modified today, display modification time, not "Today"
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkFileChooser
unspecified
Other Linux
: Normal minor
: Small fix
Assigned To: gtk-bugs
Federico Mena Quintero
Depends on:
Blocks:
 
 
Reported: 2007-02-21 20:11 UTC by Matthew Paul Thomas (mpt)
Modified: 2008-03-06 20:03 UTC
See Also:
GNOME target: ---
GNOME version: 2.17/2.18

Attachments
Patch to only show hours and minutes with respect to today (464 bytes, patch)
2008-03-06 19:24 UTC, William Lachance 		accepted-commit_now Details | Review

Description Matthew Paul Thomas (mpt) 2007-02-21 20:11:18 UTC 
Ubuntu 6.10

When an item was last modified today, the default display should not be "Today", it should be the modification time. "Today" is implied.
Comment 1 Federico Mena Quintero 2007-02-21 21:03:09 UTC 
Nice idea!  Do you want to cook a little patch for this?  The relevant place is gtk+/gtk/gtkfilechooserdefault.c:list_mtime_data_func().
Comment 2 William Lachance 2008-03-06 19:24:15 UTC 
Created attachment 106710 [details] [review]
Patch to only show hours and minutes with respect to today

This patch makes it so that files modified today look like:

13:56

Instead off;

Today at 13:56
Comment 3 Federico Mena Quintero 2008-03-06 19:38:19 UTC 
Very nice :)  Please commit to trunk with a suitable ChangeLog.
Comment 4 Federico Mena Quintero 2008-03-06 20:03:20 UTC 
The patch committed is the same as the one shown above, but with the _() for translation.  Thanks for the patch, Will :)

2008-03-06  William Lachance <wrlach@gmail.com>

       * gtk/gtkfilechooserdefault.c: Oops, forgot to make the raw "%H:%M" 
       string localizable (as it should be). 

2008-03-06  William Lachance <wrlach@gmail.com>

       * gtk/gtkfilechooserdefault.c: Don't print "Today at" in front of
       the time for today's date. It's redudant. (see bug #410517).