GNOME Bugzilla – Bug 409779
[PATCH] Re-add UI seed support, freecell redmond-style game generation
Last modified: 2021-06-02 11:33:12 UTC
Here is my patch to re-add UI seed support and add redmond-style freecell game numbers, I estimate it is clean enough. I hope the UI change is unobtrusive enough, I am not great at designing user interfaces. The code itself was tested using gnome-games 2.16.3 (debian), I have applied my changes to the latest svn revision by hand since updating my build environment would be quite cumbersome using debian, the changes seem minor enough, just be sure to double-check. PS: The GTK, C, Scheme combo has kind of grown on me, I might use something similar in future personal projects. Cheers guys, keep up the great work, Jonathan
Created attachment 82919 [details] [review] seed support, redmond-style freecell
Thanks, I'll look at this during the 2.19.x development cycle.
Hi, Have you reviewed the patch ? Could you give me a status update so I can make any necessary modifications...thanks.
The patch doesn't apply to svn anymore since the landing of new-aisleriot.
We're past both feature and UI freeze. This will have to wait until 2.21. Jonathan if you can update your patch so it applies to svn that would help a lot to get this in. I also suggest you post a screenshot of the changed UI. That way it's easier for people to comment on that part. Thanks.
I have started to work on re-making the patch to the latest svn. Took me a while to figure out that librsvg-dev needed to be installed to properly render card themes. Expect something today or tomorrow.
Created attachment 94324 [details] [review] New patch against latest gnome-games SVN. I have re-done the patch. It brings seed selection out of hiding and enhances freecell.scm. I believe the patch is relatively clean.
Created attachment 94325 [details] Aisleriot with redmond freecell support (differences highlighted)
(Please create patches with diff -up, since that adds more context info.) I'm not sure we should re-add the seed number to the window title... but even if we do, this addition in aisleriot_window_set_game + game_name = aisleriot_util_get_display_filename(game_file); + + title = g_strdup_printf("%s #%u",game_name, seed); + g_free (game_name); + + gtk_window_set_title (GTK_WINDOW (window), title); + g_free(title); is definitely wrong; the title is set again when the game really is started and that's the only time we need to set the title. + { "ChooseSeed", GTK_STOCK_JUMP_TO, _("_Choose seed"), NULL, NULL, + G_CALLBACK (choose_seed_cb) }, Does the user understand what 'seed' means and why he'd want to choose one? Maybe "Choose game by number" or sth like that... + seed_scm = g_strdup_printf("(set-seed %u)", game->seed); + scm_c_eval_string(seed_scm); + g_free(seed_scm); That's an ugly hack. Just invoke the func with the correct API: scm_call_1 (func, scm_to_int (game->seed)) Or perhaps make it an (optional) argument to the start_game function ?
Any chance for an updated patch?
Ya, sorry, got kind of discouraged. Where would you see the game number selection dialog ?
Since this is about giving *Freecell* the ability to choose the game by number/seed, I think we should not show this UI for every game. Instead we should add a 'feature' bit for 'show seed UI' and enable that bit for freecell only.
Re-assigning to default owner.
I'm sorry but this didn't make it in before feature freeze, again. Retargeting.
UI freeze is in 4 weeks; would be good to get this in for 2.26. Patch needs to be updated (see comment 12).
(In reply to comment #15) > UI freeze is in 4 weeks; would be good to get this in for 2.26. Patch needs to > be updated (see comment 12). > Agreed, I will give this another try very soon.
(set-features droppable-feature) (set-lambda new-game button-pressed button-released button-clicked button-double-clicked game-over game-won get-hint get-options apply-options timeout droppable?) Is this the line we are talking about? (1009-1011) in freecell.scm
Feature & UI freeze is upon us again; this missed yet another cycle.
Ping?
Mass-moving only open aisleriot bugs to the new product. Search for "aisleriot-mass-move" to filter them.
Taking this as a general 'freecell' improvement bug, so I'm adding this suggestion received by email from an user: Scoring: > And if you want to add a new scoring factor to FreeCell, one of the > things I strive for the most is to move the largest number of card in > the flourish of cards to the Home cells when the game ends. The best > flourish I have ever had is 48 cards! Option to disable auto-play: > And if you add a check box that will turn the automatic play from the > tableau to the home cells off, it will be possible to have a 52 card > flourish!
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/aisleriot/-/issues/79.