After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 409291 - Put completion in URL entry
Put completion in URL entry
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Interface
git master
Other Linux
: Normal normal
: gnome-2-20
Assigned To: Epiphany Maintainers
Marco Pesenti Gritti
Depends on:
Blocks:
 
 
Reported: 2007-02-18 14:51 UTC by Xan Lopez
Modified: 2007-05-01 17:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Put completion in URL entry. (4.48 KB, patch)
2007-02-18 14:52 UTC, Xan Lopez
none Details | Review
updated version (4.95 KB, patch)
2007-04-27 17:53 UTC, Xan Lopez
none Details | Review
Yet another version (5.00 KB, patch)
2007-04-28 07:51 UTC, Xan Lopez
none Details | Review

Description Xan Lopez 2007-02-18 14:51:55 UTC
This patch implements the ephy bits needed to fix the long lived bug 318459.
Comment 1 Xan Lopez 2007-02-18 14:52:37 UTC
Created attachment 82818 [details] [review]
Put completion in URL entry.
Comment 2 Xan Lopez 2007-04-27 17:53:33 UTC
Created attachment 87159 [details] [review]
updated version
Comment 3 Xan Lopez 2007-04-28 07:51:48 UTC
Created attachment 87179 [details] [review]
Yet another version

Don't select anything, simply put the tentative selection in the entry.
Comment 4 Xan Lopez 2007-05-01 17:12:19 UTC
2007-05-01  Xan Lopez  <xan@gnome.org>

	* lib/widgets/ephy-location-entry.c:
	* lib/widgets/ephy-location-entry.h:
	* src/ephy-completion-model.c:
	* src/ephy-completion-model.h:
	* src/ephy-location-action.c:

	Copy the items on the completion list as the user moves through
	them. The original input can be restored pressing Esc. The tentative
	completion can be made definitive pressing Left or Right.

	Fixes #409291, #102528