GNOME Bugzilla – Bug 408585
update icon artwork to comply with tango style guidelines
Last modified: 2010-04-16 15:18:05 UTC
There's a couple of artwork that needs an update.
The capplet icon itself (all sizes). FOr changing passwords, there seems to be a lock icon, needed at 48x48 and having 2 states.
There is also gnome-about-me-bulb-off.png and gnome-about-me-bulb-on.png, I'm not sure where they are used though.
Created attachment 82681 [details]
icon for the .desktop file
Currently the icon ships with gnome-icon-theme and is called about-me.png, which doesn't fit into the naming scheme defined by the icon naming spec draft. Need to ponder an appropriate name.
Correction, it's actually called user-info.png, not about-me.
Created attachment 82689 [details]
the lock icons for authorization in about-me
They come in both SVG and PNG formats, as rsvg needs to get bug #341304 fixed before it renders it properly.
Commited to gnome-icon-theme in the end.
D'oh, the lock icons still need to go in gnome-control-center.
If you've added these to gnome-icon-theme, shouldn't the About Me capplet be using icons from the theme rather than installing it's own?
Only the app icon has been added to the gnome icon theme. Rodney, what do you reckon would be best for the authorization/lock keys?
The title icon is the old style icon still, i think it need some patch to use git icon instead of its own.
I think we should finalize on the bug, first, I find no icon in the naming-spec that related to 'about-me', so I think the app icon definitely does not belong to theme icon instead it will be capplet's custom named icon. And IMHO, should we add the authorization/lock key to git so it can be reused on other apps aswell? Again, what do you reckon Dobey?
I believe that g-i-t should not ship the app icon, instead g-c-c should ship it under /usr/share/icons/hicolor.
I am really confused about where should the icons go to? Is it /usr/share/icons/hicolor OR is it /usr/share/<appname>/icons/hicolor? According to http://live.gnome.org/GnomeGoals/AppIcon, it seems to me the latter location is the right one.... (confused still)
gnome-icon-theme 2.29.1 now ships with two new status icons - changes-prevent and changes-allow. about-me should simply look those up for the dialog.
Created attachment 158310 [details] [review]
Patch for using changes-prevent and changes-allow from the icon-them instead of the outdated lock-icons. Guess that would be one of those nice to have improvements for a polished look in GNOME3 ;-)
Comment on attachment 158310 [details] [review]
Do you have access to git? Don't forget to remove those icons, too.
Patch committed to master