GNOME Bugzilla – Bug 408295
Remove "detachable toolbar" option from the ui properties capplet
Last modified: 2007-08-07 18:22:44 UTC
The detachable toolbar doesn't work well. Most applications don't use Bonobo, or its toolbar, so they can't be detached anyway. Given that only a few BonoboUI-powered apps are left, and that most bug reports about that option is that it doesn't work for such and such application, I think it should be removed from the UI, and made into a GConf-only setting. An example bug report: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=223007
Created attachment 82667 [details] [review] gnomecc-remove-detachable-toolbars.patch
I'm all for removing the option, but if we still "support" the option in GConf, shouldn't the toolbar preview in the capplet also respect it even if it doesn't allow changing it?
That's what I told myself after removing all this code.
Created attachment 82877 [details] [review] gnomecc-remove-detachable-toolbars-2.patch
That's far less code removed...
Hm, according to GConf docs (and the rest of the code), the signal should be "value_changed". Both seem to work, however. I'm not sure I like the change for loading the glade file, otherwise looks ok to commit after the freeze lifts.
(In reply to comment #6) > Hm, according to GConf docs (and the rest of the code), the signal should be > "value_changed". Both seem to work, however. Usually, the signal entry in the function table uses "_", the signal definition uses "-". This can be changed... > I'm not sure I like the change for loading the glade file, otherwise looks ok > to commit after the freeze lifts. I use the glade change to allow me to load the interface without installing it. Works well for its purpose. The proper fix would be to error out properly when the glade file can't be found...
The option's gone in the new appearance capplet. Closing.