GNOME Bugzilla – Bug 407647
Indicate the tree level, expanded state, and child nodes in the Pidgin buddy list.
Last modified: 2008-07-22 19:32:48 UTC
In Gaim version 2.0.0 beta 4, the structure of the buddy list was changed, necessitating a corresponding change in Orca (see bug #376791). While we now have access to the buddy list in these later versions of Gaim, Orca does not indicate the tree level of items as you navigate. As a result no distinction is made between groups and individual "buddies". If possible, Orca should indicate the tree level of items in the (post 2.0 beta 3.1) buddy list. This is a tracking bug for atk/gail bug #395781. See that bug for more details.
Removing target milestone from [blocked] bugs. We have little control over them, so we're better off letting priority and severity be our guide for poking the related components.
Created attachment 99169 [details] [review] take 1 Li posted a patch to Gail. Having it is necessary for my patch to work. Li's patch can be found here: http://bugzilla.gnome.org/show_bug.cgi?id=474504#c7 The combined result of both patches is (hopefully) the following: 1. We indicate the tree level (but wait, there's more!) 2. When arrowing among items, we indicate the expandedness of the node. If the node is expanded and we're using the verbose level of speech, it should also indicate the number of children. 3. When expanding/collapsing the current node, it should indicate the change in state. I think I got all of the issues. Will, thoughts?
Take 2 will include defensive code because we can't count on everyone have the latest gail. (I'll look at that later this evening).
Take 2 will also address the whereAmI-related issues.
Created attachment 99180 [details] [review] Take 2 This version does what the previous version did plus: 1. Does some checking before we attempt to use the new object provided to us by the Gail patch. 2. Adds a custom whereAmI to gaim.py Will before I asked for your thoughts. Then I immediately found new issues. I don't want to jinx myself, but.... Thoughts? :-)
Created attachment 99182 [details] [review] minor adjustment in the custom whereAmI
Looks like a nice workaround to me. Thanks! At some point in the future, perhaps so distant that it doesn't event warrant a bug or RFE, we might want to investigate what it would mean for the client to give non-negative column numbers to hidden columns. Joanie and I discussed this yesterday, though, and realize it might expose problems in scripts that make an assumption about the visibility of columns with non-negative index numbers (e.g., Evolution.py). Again, just something to keep in the depths of our minds and not something to perseverate on right now. Thanks Joanie!
Thanks Will! If it's alright with you, I would feel better committing this patch after it's gone through some more testing, both without the Gail patch and with it. Mike and Rich, mind giving it a go? Without the Gail patch, but with my patch you should see no difference. With the Gail patch and my patch, you should see the reported bug fixed. :-) I think I'd also feel better committing this patch once Li has committed his. If for some reason the decision is made to do things differently on the Gail side, this patch may no longer be applicable. Changing the status to [testing required] and adding Li's bug as a depends. Optimistically setting the target milestone to the next release. :-)
Li's patch has been checked in so there's no longer a need to patch Gail in order to test my patch; merely get the latest Gail. Thanks!
I've just tested this one with the latest gail and it looks good to me.
I just re-tested this "one more time to be sure" (or so I thought) with the intent of checking it in. Alas, something seems to have changed somewhere as I'm now getting sporadic announcements of the tree levels for buddies even though the level has not changed. :-( I'll look at this tomorrow.
Now I can't reproduce the problem and the patch seems to be doing the right thing. Go figure.... Patch committed, moving to pending. Please be on the lookout for the sporadic level announcements.
This one is now working fine for me.
Thanks Mike. Closing as FIXED.