GNOME Bugzilla – Bug 405821
Should use gnome-doc-utils
Last modified: 2008-03-10 16:41:01 UTC
So that it can respect the --disable-scrollkeeper configure argument. Currently, there's no way to disable the scrollkeeper-update run during installation, which isn't particularly nice when building packages.
Bug #346905 contains information on this was done for Totem.
Created attachment 88119 [details] [review] the filename says all Translation part to do see http://live.gnome.org/GnomeDocUtilsTranslationMigration
If it's tested, please apply. I have no idea how this stuff works. :-).
(In reply to comment #3) > If it's tested, please apply. I have no idea how this stuff works. :-). > I just followed the wiki instructions. Someone advised should review it before it is applied. I still don't have a svn account. I made a request some time ago, but olav wanted me to find a maintainer to vouch me. Maybe you could help me? (RT#2454) Thanks!
How to? Just email him? I'll poke him on IRC, maybe that helps.
The patch looks good (it's nice, has minuses and pluses in it, so it must be ok). If it's tested, I'd say go ahead and commit.
Very thoughtful reply, Danilo, thanks. Couldn't have done it without you. ;-).
Always glad to help :)
Thanks for the review Danilo! Patch applied with some fix. Seems to work for Gentoo guys ;)
I fixed the configure.in not to check for scrollkeeper and launch GNOME_DOC_INIT instead, on top of the current patch.
(In reply to comment #10) > I fixed the configure.in not to check for scrollkeeper and launch > GNOME_DOC_INIT instead, on top of the current patch. > ah.. un oubli? oups :).. Strange that the patch was working then.. By curiosity, how did you noticed?
(In reply to comment #11) > ah.. un oubli? oups :).. > > Strange that the patch was working then.. > > By curiosity, how did you noticed? Left-over bits from my own attempt at converting the docs to gnome-doc-utils ;)
The .omf.in files were not commited; this broke library.gnome.org last night :(
I can commit now. is it fine?
committed
Marc-Andre: Does what you committed build for you? It dies for me because the Spanish docs are missing maintainer/description (the same as the change you committed to the C docs) Could you have LINGUAS set in your build environment?
(In reply to comment #16) > Marc-Andre: Does what you committed build for you? It dies for me because > the Spanish docs are missing maintainer/description (the same as the change > you committed to the C docs) > > Could you have LINGUAS set in your build environment? Owen: I don't have LINGUAS in build env. I compiled a fresh checkout and got beta@elmarco-laptop:~/git/gnome2/gnome-media/gnome-cd/doc$ make es/gnome-cd.xml:41: parser error : Entity 'oacute' not defined <publishername> Proyecto de documentación de GNOME </publishername> ^ It first looks like a translation issue. Though I did. gnome-media/gnome-cd/doc$ make clean gnome-media/gnome-cd/doc$ make -> with success...
I have the feeling that all those files should be removed: (but make clean does not remove the legal.xml...) ./gnome-cd/doc/de/gnome-cd.xml ./gnome-cd/doc/de/legal.xml ./gnome-cd/doc/es/legal.xml ./gnome-cd/doc/es/gnome-cd.xml ./gnome-cd/doc/fr/gnome-cd.xml ./gnome-cd/doc/it/gnome-cd.xml ./gnome-cd/doc/it/legal.xml ./gnome-cd/doc/ja/gnome-cd.xml ./gnome-cd/doc/ja/legal.xml ./gnome-cd/doc/ko/gnome-cd.xml ./gnome-cd/doc/ko/legal.xml ./gnome-cd/doc/nl/gnome-cd.xml ./gnome-cd/doc/nl/legal.xml ./gnome-cd/doc/sv/gnome-cd.xml ./gnome-cd/doc/uk/gnome-cd.xml ./gnome-cd/doc/uk/legal.xml ./gnome-cd/doc/zh_CN/gnome-cd.xml ./gnome-cd/doc/zh_CN/legal.xml ./gnome-cd/doc/zh_TW/gnome-cd.xml ./gnome-cd/doc/zh_TW/legal.xml ./grecord/doc/de/grecord.xml ./grecord/doc/de/legal.xml ./grecord/doc/es/grecord.xml ./grecord/doc/es/legal.xml ./grecord/doc/es/gnome-sound-recorder.xml ./grecord/doc/fr/gnome-sound-recorder.xml ./grecord/doc/it/grecord.xml ./grecord/doc/it/legal.xml ./grecord/doc/ja/grecord.xml ./grecord/doc/ja/legal.xml ./grecord/doc/ko/grecord.xml ./grecord/doc/ko/legal.xml ./grecord/doc/sv/gnome-sound-recorder.xml ./grecord/doc/uk/gnome-sound-recorder.xml ./grecord/doc/zh_CN/grecord.xml ./grecord/doc/zh_CN/legal.xml ./grecord/doc/zh_TW/grecord.xml ./grecord/doc/zh_TW/legal.xml ./grecord/doc/oc/gnome-sound-recorder.xml ./gst-mixer/doc/uk/gnome-volume-control.xml ./gst-mixer/doc/uk/legal.xml ./gst-mixer/doc/es/gnome-volume-control.xml ./gst-mixer/doc/fr/gnome-volume-control.xml ./gst-mixer/doc/oc/gnome-volume-control.xml ./gst-mixer/doc/sv/gnome-volume-control.xml ./gstreamer-properties/help/uk/gstreamer-properties.xml ./gstreamer-properties/help/uk/legal.xml ./gstreamer-properties/help/es/gstreamer-properties.xml ./gstreamer-properties/help/oc/gstreamer-properties.xml ./gstreamer-properties/help/sv/gstreamer-properties.xml ./gstreamer-properties/help/fr/gstreamer-properties.xml
Wiki http://live.gnome.org/GnomeDocUtilsMigrationHowTo just says: "Remove leftovers such as help/C/Makefile.am and help/C/*.omf" That, I think I did. Looks like the LANG/Makefile(s) are useless too
If I remember, we should distinguish languages that already updated to be gnome-doc-utils compliant and the others: * gnome-doc-utils converted translations: LANG directory should only contain LANG.po and figures subdir. LANG should be listed in DOC_LINGUAS var in main doc Makefile. See eg. http://svn.gnome.org/svn/gnome-media/trunk/grecord/doc/fr/ * other non updated translations: All legacy files can be left in place (.xml, .omf) LANG should be listed in SUBDIRS var in main doc Makefile See Makefile of eog/help (http://svn.gnome.org/viewcvs/eog/trunk/help/Makefile.am) Hope this helps.
Changing severity to Blocker; this is consistently breaking jhbuild. If it hasn't been fixed in a day or two, we should just remove 'es' from DOC_LINGUAS, which is easy to do. Or if someone wants to follow Claude's instructions to fix it properly... I don't know why it isn't breaking for Marc-Andre. With current version of gnome-doc-utils, it looks obvious that it will break from the gnome-doc-utils code ... not having the author/abstract is a fatal error.
Making this a blocker isn't going to do anything, because only gnome-media maintainers are reading this and this is not my thing. Move this to i18n/es or CC the spanish people or fix it yourself if it's really that easy (you have permission to commit anything to svn if that's what you were waiting for).
The patch is buggy in another way too: the gstreamer-properties and gnome-sound-recorder docs have the same UUID: ./gstreamer-properties/help/gstreamer-properties.omf.in: <relation seriesid="ab608794-6437-11d6-8710-e52e6a5e9920"/> ./grecord/doc/gnome-sound-recorder.omf.in: <relation seriesid="ab608794-6437-11d6-8710-e52e6a5e9920"/> Also e.g. gnome-cd/doc/es/ contains a es.po file but _also_ the old, obsolete *.omf and legal.xml files; those should have been removed. However that doesn't seem to break the build; I can confirm that the build succeeds like in comment 17.
Ronald: The gnome-media maintainers have ultimate responsibility that their module keeps on building, I think the blocker status was appropriate. I've taken basic corrective action, so moving back to a normal status. 2007-10-05 Owen Taylor <otaylor@redhat.com> * Makefile.am: Remove es from DOC_LINGUAS, since it is breaking the build with current gnome-doc-utils (#405821)
It seems the build failure was caused by the left-over gnome-cd.xml and legal.xml files in gnome-cd/doc/es. After svn removing them, a clean checkout of gnome-media (+ re-adding "es" to DOC_LINGUAS) builds without errors; so I've re-enabled the es translation in svn.
(In reply to comment #25) > It seems the build failure was caused by the left-over gnome-cd.xml and > legal.xml files in gnome-cd/doc/es. After svn removing them, a clean checkout > of gnome-media (+ re-adding "es" to DOC_LINGUAS) builds without errors; so I've > re-enabled the es translation in svn. > ok, thanks! can we consider this bug closed? The only issue I see left is the dulicate use of UUID. However, it has been like that for years (I checked the 2.16 branch). We should open a different bug or someone with a good solution should just fix that. I don't know how to deal with it.
Simply use scrollkeeper-gen-seriesid to generate new uids for those docs, and commit that :)
Created attachment 106985 [details] [review] [1/1] 2008-03-10 Marc-Andre Lureau <marcandre.lureau@gmail.com> * gstreamer-properties/help/gstreamer-properties.omf.in: Generate a seriesid different from g-s-r, as suggested by ChPe: 4b74e078-eebf-11dc-9b4b-a29c33073fb7 (Closes #405821) --- ChangeLog | 7 +++++++ .../help/gstreamer-properties.omf.in | 2 +- 2 files changed, 8 insertions(+), 1 deletions(-)
closing.