After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 405317 - Total match count is wrong with excluded directories
Total match count is wrong with excluded directories
Status: RESOLVED FIXED
Product: beagle
Classification: Other
Component: General
0.2.15
Other All
: Normal normal
: ---
Assigned To: Beagle Bugs
Beagle Bugs
Depends on:
Blocks:
 
 
Reported: 2007-02-07 11:12 UTC by stephan.hegel
Modified: 2007-02-12 21:00 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
adjust the count if HitFilter rejects any hit (806 bytes, patch)
2007-02-10 19:28 UTC, Debajyoti Bera
committed Details | Review

Description stephan.hegel 2007-02-07 11:12:19 UTC
Please describe the problem:
After adding an exclude path to the beagle configuration the indexer doesn't remove previously indexed files from the database. The files don't show up in beagle-query or beagle-search anymore, but unwanted messages like "Showing 8 of 9 matches" pop up in beagle-search where the 9th is that one which is located in the newly excluded path.

The calculation of the number of total matches seems to be wrong, doesn't care about the new excludes.

Steps to reproduce:



Actual results:


Expected results:


Does this happen every time?


Other information:
dBera commented on this:
Arghh... when I added the code to get the total number of matches I didnt realize it would bite back this way :-) . You are right, the ignored document is not immediately removed from the index (that would require recrawling the whole tree to figure out what should be ignored) but silently removed from search results. The document itself is present in the index, as evident from the count. The count should be updated to hide the "little cheating" - thats a bug.
Comment 1 Joe Shaw 2007-02-07 18:40:28 UTC

*** This bug has been marked as a duplicate of 169222 ***
Comment 2 Debajyoti Bera 2007-02-10 19:28:14 UTC
Created attachment 82292 [details] [review]
adjust the count if HitFilter rejects any hit

This bug is not strictly a duplicate of the #169222. The demand is pretty small - just that the actual count be correct.

Stephan, can you test if the attached patch corrects the problem ?
Comment 3 stephan.hegel 2007-02-11 04:46:02 UTC
I've checked with rev 3413 plus your patch. The count of total matches is calculated and displayed correctly now, even after adding a new exclude path. Thanks.
Comment 4 Debajyoti Bera 2007-02-11 08:21:42 UTC
Thanks. Checked in the fix, r3415.
Comment 5 Joe Shaw 2007-02-12 21:00:57 UTC
Fixing the summary to reflect the fix that was checked in.