After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 403961 - spider options order
spider options order
Status: RESOLVED WONTFIX
Product: gnome-games-superseded
Classification: Deprecated
Component: general
2.17.x
Other Linux
: Normal enhancement
: gnome-2-22
Assigned To: GNOME Games maintainers
GNOME Games maintainers
Depends on:
Blocks:
 
 
Reported: 2007-02-03 15:41 UTC by Christian Persch
Modified: 2012-01-31 23:19 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement

Attachments
proposed patch (2.42 KB, patch)
2007-02-03 15:45 UTC, Christian Persch 		committed Details | Review

Description Christian Persch 2007-02-03 15:41:25 UTC 
Bug 393709 added 4, 2 and 1-suit options to spider. The order is currently 4, 2, 1; but I think they should be ordered in ascending difficulty: 1, 2, 4.
Comment 1 Christian Persch 2007-02-03 15:45:23 UTC 
Created attachment 81822 [details] [review]
proposed patch
Comment 2 Andreas Røsdal 2007-02-03 21:21:12 UTC 
This change looks good, you can commit it.

(At least unless this breaks the current UI freeze)
Comment 3 Andreas Røsdal 2007-05-01 15:07:08 UTC 
Patch applied to SVN.
Comment 4 Christian Persch 2007-06-15 11:07:01 UTC 
Reopening.

I think this caused the following problem: when you've played spider in 2.18, and set the options there, and then use 2.19, the options are interpreted differently. The default value was 4-suit which is option 1, but now option 3, so it uses 1-suit instead of 4-suit.
Comment 5 Christian Persch 2007-06-23 12:45:55 UTC 
Setting patch status.

I don't see any way to change the order in the menus without changing the options values; so I think this should be backed out.
Comment 6 Christian Persch 2007-09-09 21:17:39 UTC 
Andreas: I think this should be reverted before the 2.20 release, because of comment 4. Ok to do so before code freeze on monday ?
Comment 7 Thomas Andersen 2007-09-10 08:24:56 UTC 
Won't backing this out entirely mess with the translations? But the changes to rules/spider.scm should be backed out imo.
Comment 8 Christian Persch 2007-09-10 19:04:05 UTC 
Right, we only need to revert the spider.scm part; the docs update is independent and didn't even belong in this bug.

        * rules/spider.scm: Revert the spider options order change from bug
        #403961 since it breaks on upgrade.

Resolving as WONTFIX.
Comment 9 Robert Ancell 2012-01-31 23:19:38 UTC 
This bug is being reassigned to the "general" component so we can close the aisleriot bugzilla component.  Apologies for the mass email!