After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 403959 - [artdisplay] refuses to save images to multi-artist albums
[artdisplay] refuses to save images to multi-artist albums
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: Plugins (other)
0.9.7
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks: 412853
 
 
Reported: 2007-02-03 15:37 UTC by Ed Catmur
Modified: 2007-03-03 05:00 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
15local-save-multi-artist-album.patch (824 bytes, patch)
2007-02-03 15:37 UTC, Ed Catmur
committed Details | Review

Description Ed Catmur 2007-02-03 15:37:18 UTC
The LocalCoverArtSearch saving logic is wrong:

if u_entry:
    u_artist, u_album = [db.entry_get (u_entry, x) for x in [rhythmdb.PROP_ARTIST, rhythmdb.PROP_ALBUM]]
    if (artist, album) != (u_artist, u_album):
        print "Not saving local art; encountered media with different artist/album (%s, %s, %s)" % (uri, u_artist, u_album)

This does the wrong thing on albums with multiple artists; it should only check that the album is the same.
Comment 1 Ed Catmur 2007-02-03 15:37:38 UTC
Created attachment 81821 [details] [review]
15local-save-multi-artist-album.patch
Comment 2 James "Doc" Livingston 2007-03-03 05:00:14 UTC
Committed to svn trunk, thanks.