Bug 403377 – [PATCH] Frequent gnome-panel applet crashes on startup

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 403377 - [PATCH] Frequent gnome-panel applet crashes on startup


Summary:	[PATCH] Frequent gnome-panel applet crashes on startup


Status:	RESOLVED FIXED

Product:	libwnck
Classification:	Core
Component:	pager
Version:	2.18.x
Hardware:	Other Linux

Importance:	Normal critical
Target Milestone:	---
Assigned To:	libwnck maintainers
QA Contact:	libwnck maintainers

URL:
Whiteboard:

Duplicates:	360742 432554 441727 441728 442969 442976 445791 454589 455145 459786 461124 467028 470130 480659 486213 494545 505927 506143 506875 506880 511806 521313 521314 521315 521316 521318 521319 (view as bug list)
Depends on:
Blocks:

Reported:	2007-02-01 22:16 UTC by Kim Woelders
Modified:	2008-03-09 09:21 UTC

See Also:
GNOME target:	---
GNOME version:	2.17/2.18

Description Kim Woelders 2007-02-01 22:16:37 UTC

When starting gnome-panel at startup I often get like

Backtrace was generated from '/usr/libexec/WindowNavigationApplets'
...

+ Trace 107230

#0 __kernel_vsyscall
#1 __waitpid_nocancel
from /lib/libpthread.so.0
#2 gnome_gtk_module_info_get
from /usr/lib/libgnomeui-2.so.0
#3 <signal handler called>
#4 wnck_workspace_get_width
from /usr/lib/libwnck-1.so.18
#5 gtk_marshal_BOOLEAN__VOID
from /usr/lib/libgtk-x11-2.0.so.0
#6 g_value_set_static_boxed
from /lib/libgobject-2.0.so.0
#7 g_closure_invoke
from /lib/libgobject-2.0.so.0
#8 g_signal_override_class_closure
from /lib/libgobject-2.0.so.0


This turns out to be caused by a missing NULL check of active_space in wnck_pager_draw_workspace().

The problem is fixed by the patch below:

diff -u -r1.59 pager.c
--- libwnck/pager.c     2 Dec 2006 11:47:25 -0000       1.59
+++ libwnck/pager.c     1 Feb 2007 21:29:00 -0000
@@ -930,7 +930,7 @@
                                      GDK_RGB_DITHER_MAX,
                                      0, 0);
     }
-  else
+  else if (active_space)
     {
       int vx, vy, vw, vh; /* viewport */
       double width_ratio, height_ratio;

Comment 1 Sebastien Bacher 2007-03-29 21:36:10 UTC

Ubuntu bug with a crash similar to the one described: https://launchpad.net/bugs/98734

"[apport] gnome-panel crashed with SIGSEGV in wnck_workspace_get_width()
...
Binary package hint: gnome-panel

Feisty Beta with compiz effects turn off
...
libwnck18 2.18.0-0ubuntu1
...
.

+ Trace 123347

Thread 1 (process 6980)

#0 wnck_workspace_get_width
at workspace.c line 293
#1 wnck_pager_expose_event
at pager.c line 954
#2 _gtk_marshal_BOOLEAN__BOXED
at gtkmarshalers.c line 84
#3 IA__g_closure_invoke
at gclosure.c line 490
#4 signal_emit_unlocked_R
at gsignal.c line 2478
#5 IA__g_signal_emit_valist
at gsignal.c line 2209
#6 IA__g_signal_emit
at gsignal.c line 2243
#7 gtk_widget_event_internal
at gtkwidget.c line 3915
#8 IA__gtk_main_do_event
at gtkmain.c line 1556
#9 gdk_window_process_updates_internal
at gdkwindow.c line 2338
#10 IA__gdk_window_process_all_updates
at gdkwindow.c line 2401
#11 gtk_container_idle_sizer
at gtkcontainer.c line 1113
#12 IA__g_main_context_dispatch
at gmain.c line 2045
#13 g_main_context_iterate
at gmain.c line 2677
#14 IA__g_main_loop_run
at gmain.c line 2881
#15 IA__gtk_main
at gtkmain.c line 1177
#16 main
at main.c line 98

Comment 2 Elijah Newren 2007-04-15 01:06:06 UTC

Hi Kim,

That patch looks fine to me; go ahead and apply.  (Please make sure to also use -p in the future when making patches.)

Thanks!

Comment 3 Kim Woelders 2007-04-15 08:04:55 UTC

I don't have commit access...

Comment 4 Elijah Newren 2007-04-16 03:46:15 UTC

Okay, I committed it.  Thanks for the fix!  :)

2007-04-15  Elijah Newren  <newren gmail com>

	Patch from Kim Woelders to fix #403377 (crash on startup).

	* libwnck/pager.c (wnck_pager_draw_workspace): avoid a crash when
	there is no active workspace yet

Comment 5 Vincent Untz 2007-04-29 23:21:09 UTC

*** Bug 360742 has been marked as a duplicate of this bug. ***

Comment 6 Vincent Untz 2007-04-30 18:12:13 UTC

*** Bug 432554 has been marked as a duplicate of this bug. ***

Comment 7 Vincent Untz 2007-05-28 08:29:34 UTC

*** Bug 441728 has been marked as a duplicate of this bug. ***

Comment 8 Vincent Untz 2007-05-28 08:29:37 UTC

*** Bug 441727 has been marked as a duplicate of this bug. ***

Comment 9 Christian Kirbach 2007-06-02 11:51:43 UTC

*** Bug 442969 has been marked as a duplicate of this bug. ***

Comment 10 Christian Kirbach 2007-06-02 11:51:48 UTC

*** Bug 442976 has been marked as a duplicate of this bug. ***

Comment 11 Pedro Villavicencio 2007-06-10 02:06:23 UTC

*** Bug 445791 has been marked as a duplicate of this bug. ***

Comment 12 palfrey 2007-07-07 21:33:56 UTC

*** Bug 454589 has been marked as a duplicate of this bug. ***

Comment 13 Vincent Untz 2007-07-10 13:52:14 UTC

*** Bug 455145 has been marked as a duplicate of this bug. ***

Comment 14 Vincent Untz 2007-07-25 17:53:01 UTC

*** Bug 459786 has been marked as a duplicate of this bug. ***

Comment 15 Pascal Terjan 2007-08-25 06:20:40 UTC

*** Bug 467028 has been marked as a duplicate of this bug. ***

Comment 16 Susana 2007-08-27 20:10:32 UTC

*** Bug 461124 has been marked as a duplicate of this bug. ***

Comment 17 Susana 2007-08-27 20:10:50 UTC

*** Bug 470130 has been marked as a duplicate of this bug. ***

Comment 18 Vincent Untz 2007-10-11 17:37:36 UTC

*** Bug 480659 has been marked as a duplicate of this bug. ***

Comment 19 Vincent Untz 2007-10-15 19:19:07 UTC

*** Bug 486213 has been marked as a duplicate of this bug. ***

Comment 20 Vincent Untz 2007-11-13 08:54:15 UTC

*** Bug 494545 has been marked as a duplicate of this bug. ***

Comment 21 Susana 2008-01-08 21:34:23 UTC

*** Bug 505927 has been marked as a duplicate of this bug. ***

Comment 22 Susana 2008-01-08 21:34:31 UTC

*** Bug 506143 has been marked as a duplicate of this bug. ***

Comment 23 Susana 2008-01-08 21:34:40 UTC

*** Bug 506875 has been marked as a duplicate of this bug. ***

Comment 24 Susana 2008-01-08 21:34:58 UTC

*** Bug 506880 has been marked as a duplicate of this bug. ***

Comment 25 Philip Withnall 2008-01-24 17:02:34 UTC

*** Bug 511806 has been marked as a duplicate of this bug. ***

Comment 26 Gianluca Borello 2008-03-09 09:21:06 UTC

*** Bug 521313 has been marked as a duplicate of this bug. ***

Comment 27 Gianluca Borello 2008-03-09 09:21:13 UTC

*** Bug 521314 has been marked as a duplicate of this bug. ***

Comment 28 Gianluca Borello 2008-03-09 09:21:20 UTC

*** Bug 521315 has been marked as a duplicate of this bug. ***

Comment 29 Gianluca Borello 2008-03-09 09:21:25 UTC

*** Bug 521316 has been marked as a duplicate of this bug. ***

Comment 30 Gianluca Borello 2008-03-09 09:21:31 UTC

*** Bug 521318 has been marked as a duplicate of this bug. ***

Comment 31 Gianluca Borello 2008-03-09 09:21:36 UTC

*** Bug 521319 has been marked as a duplicate of this bug. ***