After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 403191 - Avoid markup in c source files
Avoid markup in c source files
Status: RESOLVED FIXED
Product: gnome-main-menu
Classification: Other
Component: libslab
unspecified
Other Linux
: High trivial
: ---
Assigned To: Jim Krehl
GNOME main menu maintainers
Depends on:
Blocks:
 
 
Reported: 2007-02-01 12:17 UTC by Gabor Kelemen
Modified: 2012-09-05 20:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Trivial fix (2.68 KB, patch)
2007-02-01 12:19 UTC, Gabor Kelemen 		none Details | Review
Trivial fix, this time without build-breaking typos (2.68 KB, patch)
2007-02-01 23:20 UTC, Gabor Kelemen 		none Details | Review
Really working patch (2.68 KB, patch)
2007-02-02 00:08 UTC, Gabor Kelemen 		none Details | Review
Another patch for new strings (1.42 KB, patch)
2009-08-11 23:22 UTC, Gabor Kelemen 		committed Details | Review

Description Gabor Kelemen 2007-02-01 12:17:49 UTC 
As translators often say, please don't include markup in translateable
messages. Move the markup outside of the gettext call.  See
http://developer.gnome.org/doc/tutorials/gnome-i18n/developer.html#avoid-markup

Affected messages:

#: ../libslab/app-shell.c:709
msgid ""
"<span size=\"large\"><b>No matches found.</b> </span><span>\n"
"\n"
" Your filter \"<b>%s</b>\" does not match any items.</span>"

#: ../libslab/application-tile.c:310
msgid "<b>Start %s</b>"

#: ../libslab/document-tile.c:183
msgid "<b>Open with \"%s\"</b>"
Comment 1 Gabor Kelemen 2007-02-01 12:19:03 UTC 
Created attachment 81653 [details] [review]
Trivial fix
Comment 2 Gabor Kelemen 2007-02-01 23:20:13 UTC 
Created attachment 81713 [details] [review]
Trivial fix, this time without build-breaking typos
Comment 3 Gabor Kelemen 2007-02-02 00:08:20 UTC 
Created attachment 81717 [details] [review]
Really working patch
Comment 4 Claude Paroz 2009-08-06 11:51:42 UTC 
Could a maintainer please review the patch, so as it may be committed before string freezed?
Comment 5 Claude Paroz 2009-08-06 11:55:13 UTC 
CC'ed Cosimo, as it has lastly been active on the module.
Comment 6 Cosimo Cecchi 2009-08-08 16:53:06 UTC 
Fixed in libslab master.

commit da80cf7ef30fc0c03aec3ff17a4675822d07a265
Author: Cosimo Cecchi <cosimoc@gnome.org>
Date:   Sat Aug 8 18:51:28 2009 +0200

    Avoid markup in translatable strings.
    
    Fix bug #403191. Patch by Gabor Kelemen.
Comment 7 Gabor Kelemen 2009-08-11 23:22:54 UTC 
Created attachment 140502 [details] [review]
Another patch for new strings

There are still some...
Comment 8 Tobias Mueller 2010-04-11 20:40:51 UTC 
Comment on attachment 140502 [details] [review]
Another patch for new strings

Nice patch. I'd say it's to commit after branched for gnome-2.30.
Maintainers: Any objections?
Comment 9 André Klapper 2011-01-22 14:13:26 UTC 
ping - can this get a commit now, please?
Comment 10 André Klapper 2011-03-04 12:06:12 UTC 
ping - can this get a commit now, please?
Comment 11 André Klapper 2012-01-12 15:10:48 UTC 
ping - can this get a commit now, please?
Comment 12 Piotr Drąg 2012-09-05 20:19:23 UTC 
Pushed along with a a patch minimizing the damage to existing translations.